linux-kernel - Re: [PATCH] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <kqtaw37b6upcuorurnccs6gqvp2aj33afanxnqye7txkmr5be6@k2omfqynjscv>
Date: Mon, 8 Sep 2025 05:27:51 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>, 
	Rich Felker <dalias@...c.org>, John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>, 
	Arnd Bergmann <arnd@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>, linux-sh@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sh: mach-rsk: rsk7203: use static device properties for
 LEDs and GPIO buttons

On Wed, Aug 13, 2025 at 03:50:09PM +0300, Andy Shevchenko wrote:
> On Mon, Aug 11, 2025 at 03:44:57PM -0700, Dmitry Torokhov wrote:
> > Convert the board to use static device properties instead of platform
> > data to describe LEDs and GPIO-connected buttons on the board, so
> > that support for platform data can be removed from gpio-keys and other
> > drivers, unifying their behavior.
> 
> ...
> 
> > --- a/arch/sh/boards/mach-rsk/devices-rsk7203.c
> > +++ b/arch/sh/boards/mach-rsk/devices-rsk7203.c
> 
> >  #include <linux/gpio.h>
> 
> Do we still need this one?

Yes, at least this one still uses gpio_request() for configuring some
GPIOs, so we need to keep it at least for now.

> 
> Ditto for the rest similar cases.

I'll review them to make sure they are still needed.

Thanks.

-- 
Dmitry