linux-kernel - Re: [PATCH] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bccfde5bca138b8f3489f517ea62168ec4658336.camel@physik.fu-berlin.de>
Date: Thu, 11 Sep 2025 13:39:58 +0200
From: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>, Andy Shevchenko
	 <andriy.shevchenko@...ux.intel.com>
Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>, Rich Felker
 <dalias@...c.org>,  Arnd Bergmann <arnd@...nel.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, linux-sh@...r.kernel.org, 	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sh: mach-rsk: rsk7203: use static device properties for
 LEDs and GPIO buttons

Hi Dmitry,

On Mon, 2025-09-08 at 05:27 -0700, Dmitry Torokhov wrote:
> On Wed, Aug 13, 2025 at 03:50:09PM +0300, Andy Shevchenko wrote:
> > On Mon, Aug 11, 2025 at 03:44:57PM -0700, Dmitry Torokhov wrote:
> > > Convert the board to use static device properties instead of platform
> > > data to describe LEDs and GPIO-connected buttons on the board, so
> > > that support for platform data can be removed from gpio-keys and other
> > > drivers, unifying their behavior.
> > 
> > ...
> > 
> > > --- a/arch/sh/boards/mach-rsk/devices-rsk7203.c
> > > +++ b/arch/sh/boards/mach-rsk/devices-rsk7203.c
> > 
> > >  #include <linux/gpio.h>
> > 
> > Do we still need this one?
> 
> Yes, at least this one still uses gpio_request() for configuring some
> GPIOs, so we need to keep it at least for now.
> 
> > 
> > Ditto for the rest similar cases.
> 
> I'll review them to make sure they are still needed.

OK, I'll look forward to your second version of the patch. I might pick it
up for v6.18 provided that we'll manage to squeeze it in in time.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913