linux-kernel - Re: [PATCH phy 13/14] dt-bindings: phy: lynx-28g: add compatible strings per SerDes and instantiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250909185858.jun4bevwqiu5zqte@skbuf>
Date: Tue, 9 Sep 2025 21:58:58 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Conor Dooley <conor@...nel.org>
Cc: Josua Mayer <josua@...id-run.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	"linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
	Ioana Ciornei <ioana.ciornei@....com>,
	Vinod Koul <vkoul@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH phy 13/14] dt-bindings: phy: lynx-28g: add compatible
 strings per SerDes and instantiation

On Tue, Sep 09, 2025 at 07:35:43PM +0100, Conor Dooley wrote:
> On Tue, Sep 09, 2025 at 02:35:43PM +0300, Vladimir Oltean wrote:
> > On Mon, Sep 08, 2025 at 04:04:45PM +0000, Josua Mayer wrote:
> > > Am 08.09.25 um 17:37 schrieb Vladimir Oltean:
> > > > On Mon, Sep 08, 2025 at 02:02:35PM +0000, Josua Mayer wrote:
> > > >>> My updated plan is to describe the schema rules for the compatible as
> > > >>> follows. Is that ok with everyone?
> > > >>>
> > > >>> properties:
> > > >>>   compatible:
> > > >>>     oneOf:
> > > >>>       - const: fsl,lynx-28g
> > > >>>         deprecated: true
> > > >>>       - items:
> > > >>>           - const: fsl,lx2160a-serdes1
> > > >>>           - const: fsl,lynx-28g
> > > >>>       - enum:
> > > missed fsl,lx2160a-serdes1
> > 
> > I didn't miss anything. "fsl,lx2160a-serdes1" is deliberately not in
> > "enum" because there's no point specifying this compatible as
> > standalone, if for backwards compatibility reasons it will always have
> > to be "fsl,lx2160a-serdes1", "fsl,lynx-28g" (it was described as
> > "fsl,lynx-28g" before), which is already covered by "items".
> 
> I think Josua was pointing out their own omission here.

Maybe, but the quoted text was my proposal.