linux-kernel - Re: [PATCH] gpio: mpsse: support bryx radio interface kit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MfSOTTBv3spbyiedpMifMyfmTkpmbvuDuKcbs5S1B+Esg@mail.gmail.com>
Date: Wed, 10 Sep 2025 15:46:03 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Mary Strodl <mstrodl@....rit.edu>
Cc: kernel test robot <lkp@...el.com>, linux-kernel@...r.kernel.org, 
	oe-kbuild-all@...ts.linux.dev, linus.walleij@...aro.org, 
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH] gpio: mpsse: support bryx radio interface kit

On Wed, Sep 10, 2025 at 3:29 PM Mary Strodl <mstrodl@....rit.edu> wrote:
>
> On Wed, Sep 10, 2025 at 03:15:46PM +0200, Bartosz Golaszewski wrote:
> > I cannot really give you much feedback because this patch should be
> > first split into smaller chunks that explain what each change is
> > doing. As it is: it's so complex, I simply don't understand it and
> > don't have enough time to try and decipher it. Please try to make it
> > into a series of smaller patches.
>
> Got it. That's why I offered to break it up.
>
> Here's the order I did the work in:
> 1. Add quirk support + brik quirk
> 2. Label format (Only a few lines, could go into 1 or 3 if preferred)
> 3. RCU stuff
>
> Is this a reasonable order for the series? This would be the easiest
> way for me to do it given what I have in git.
>
> In a perfect world, I would like to have had:
>
> 1. RCU stuff (These are effectively bugfixes)

If these are bugfixes that should be backported to stable then they
should indeed come first.

FYI: Maybe consider also adding lock guards for rcu read locks if you're at it?

Bart

> 2. Label stuff
> 3. Quirks
> 4. Brik quirk (possibly squashed into 3)
>
> Let me know what you think... Thank you!