linux-kernel - Re: [PATCH v2 7/7] can: m_can: add optional support for reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250910-gay-rigorous-kingfisher-abafca-mkl@pengutronix.de>
Date: Wed, 10 Sep 2025 16:35:56 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Markus Schneider-Pargmann <msp@...libre.com>
Cc: Chandrasekar Ramakrishnan <rcsekar@...sung.com>, 
	Vincent Mailhol <mailhol.vincent@...adoo.fr>, Patrik Flykt <patrik.flykt@...ux.intel.com>, 
	Dong Aisheng <b29396@...escale.com>, Varka Bhadram <varkabhadram@...il.com>, 
	Wu Bo <wubo.oduw@...il.com>, Philipp Zabel <p.zabel@...gutronix.de>, 
	linux-can@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v2 7/7] can: m_can: add optional support for reset

On 10.09.2025 11:32:04, Markus Schneider-Pargmann wrote:
> > diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> > index 9528af8500af..93085bf1c267 100644
> > --- a/drivers/net/can/m_can/m_can.c
> > +++ b/drivers/net/can/m_can/m_can.c

[...]

> > +	cdev->rst = devm_reset_control_get_optional_shared(cdev->dev, NULL);
> > +	if (IS_ERR(cdev->rst))
> > +		return PTR_ERR(cdev->rst);
> 
> Should this print an error message here?

makes sense

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)