linux-kernel - Re: [PATCH] fix: delete del_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK-6q+juz=VMTGkaWJKuQn=-OV4ug3j5q1YvuxK9JuZZ4SkVYw@mail.gmail.com>
Date: Wed, 10 Sep 2025 10:35:02 -0400
From: Alexander Aring <aahringo@...hat.com>
To: Alessio Attilio <alessio.attilio.dev@...il.com>
Cc: gfs2@...ts.linux.dev, linux-kernel@...r.kernel.org, teigland@...hat.com
Subject: Re: [PATCH] fix: delete del_proc_lock

Hi,

On Sat, Sep 6, 2025 at 8:55 AM Alessio Attilio
<alessio.attilio.dev@...il.com> wrote:
>
> The del_proc_lock function was originally retained for testing purposes during development of the Distributed Lock Manager (DLM).
> With testing now complete and the function no longer serving a runtime role, it is safe to remove.
>
> Reason for Removal: The function is unused in production code and was only kept temporarily for debugging and validation.
> Its presence is no longer necessary and may cause confusion or clutter.

I don't know why you come to this conclusion, the function is not in
use anymore because your previous patch [0] removes the usage of it.
Then the kernel test robot complained about it and this patch came.
You need to respin the patch [0] (preferably marked as PATCHv2) with
the additional changes to make the kernel test robot happy.

I still wait for a reproducer for this issue to get more details about
what the actual problem is and its still present in upstream DLM.

- Alex

[0] https://lore.kernel.org/gfs2/202509061809.348XSVqi-lkp@intel.com/T/#mb79fb269cac0ef77e047b6edde162c67c6267f45