linux-kernel - Re: [PATCH v1] mfd: twl4030-irq: Fix unused variable warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wm66s50g.ffs@tglx>
Date: Wed, 10 Sep 2025 17:26:23 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Haofeng Li <920484857@...com>, Tony Lindgren <tony@...mide.com>, Kevin
 Hilman <khilman@...libre.com>
Cc: Roger Quadros <rogerq@...nel.org>, Andreas Kemnade
 <andreas@...nade.info>, Aaro Koskinen <aaro.koskinen@....fi>,
 linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org, Haofeng Li
 <lihaofeng@...inos.cn>
Subject: Re: [PATCH v1] mfd: twl4030-irq: Fix unused variable warning when
 CONFIG_OF disabled

On Tue, Jun 17 2025 at 10:41, Haofeng Li wrote:
> -
> -	irq_domain_create_legacy(of_fwnode_handle(node), nr_irqs, irq_base, 0,
> +#ifdef CONFIG_OF
> +	fwnode = of_fwnode_handle(dev->of_node);
> +#endif

This #ifdeffery is horrible.

> +	irq_domain_create_legacy(fwnode, nr_irqs, irq_base, 0,

        irq_domain_create_legacy(dev_fwnode(dev), ....

Makes all of those problems go away.