linux-kernel - Re: [PATCH v1] mfd: twl4030-irq: Fix unused variable warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tencent_5D5D6F9F6C5ABBD25E4C60151B1F52CF4006@qq.com>
Date: Fri, 12 Sep 2025 18:17:50 +0800
From: Haofeng Li <920484857@...com>
To: tglx@...utronix.de
Cc: 920484857@...com,
	aaro.koskinen@....fi,
	andreas@...nade.info,
	khilman@...libre.com,
	lihaofeng@...inos.cn,
	linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org,
	rogerq@...nel.org,
	tony@...mide.com
Subject: Re: [PATCH v1] mfd: twl4030-irq: Fix unused variable warning when CONFIG_OF disabled

>This #ifdeffery is horrible.

> +	irq_domain_create_legacy(fwnode, nr_irqs, irq_base, 0,

>        irq_domain_create_legacy(dev_fwnode(dev), ....

>Makes all of those problems go away.

Thank you very much for your valuable feedback. Your suggestion to use dev_fwnode(dev) to simplify the code and avoid unnecessary #ifdef conditionals is highly appreciated. This approach indeed makes the code cleaner and more maintainable.

I have noticed that this issue has already been addressed in the latest commit, and the changes have been implemented . Therefore, I am closing this submission.

Once again, thank you for your guidance and support. If you have any further suggestions or require additional input, please feel free to let me know. I look forward to continuing to learn from your insights in future developments.

Best regards,
	lihaofeng