linux-kernel - Re: [PATCH net-next] net: devmem: expose tcp_recvmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMGbmaelbnvKymvB@mini-arch>
Date: Wed, 10 Sep 2025 08:39:05 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	ncardwell@...gle.com, kuniyu@...gle.com, dsahern@...nel.org,
	horms@...nel.org, linux-kernel@...r.kernel.org,
	Mina Almasry <almasrymina@...gle.com>
Subject: Re: [PATCH net-next] net: devmem: expose tcp_recvmsg_locked errors

On 09/09, Jakub Kicinski wrote:
> On Mon,  8 Sep 2025 10:50:45 -0700 Stanislav Fomichev wrote:
> >  				if (err <= 0) {
> 
> Should we change this condition to be err < 0, then?
> I don't see a path that'd return 0 but it's a bit odd to explicitly
> handle 0 here and then let it override copied.

As you say, we don't seem to be returning 0 from tcp_recvmsg_dmabuf, so
this is mostly about the readability. But makes sense overall, will
repost.