linux-kernel - Re: [PATCH net-next] net: devmem: expose tcp_recvmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250909183550.5bcc71d2@kernel.org>
Date: Tue, 9 Sep 2025 18:35:50 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, ncardwell@...gle.com, kuniyu@...gle.com,
 dsahern@...nel.org, horms@...nel.org, linux-kernel@...r.kernel.org, Mina
 Almasry <almasrymina@...gle.com>
Subject: Re: [PATCH net-next] net: devmem: expose tcp_recvmsg_locked errors

On Mon,  8 Sep 2025 10:50:45 -0700 Stanislav Fomichev wrote:
>  				if (err <= 0) {

Should we change this condition to be err < 0, then?
I don't see a path that'd return 0 but it's a bit odd to explicitly
handle 0 here and then let it override copied.

>  					if (!copied)
> -						copied = -EFAULT;
> +						copied = err;