linux-kernel - Re: [PATCH v2 3/7] PCI: sg2042: Add Sophgo SG2042 PCIe driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MAUPR01MB11072EF3457DA48317FBFBB09FE0EA@MAUPR01MB11072.INDPRD01.PROD.OUTLOOK.COM>
Date: Wed, 10 Sep 2025 11:20:50 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Inochi Amaoto <inochiama@...il.com>, Chen Wang <unicornxw@...il.com>,
 kwilczynski@...nel.org, u.kleine-koenig@...libre.com, aou@...s.berkeley.edu,
 alex@...ti.fr, arnd@...db.de, bwawrzyn@...co.com, bhelgaas@...gle.com,
 conor+dt@...nel.org, 18255117159@....com, kishon@...nel.org,
 krzk+dt@...nel.org, lpieralisi@...nel.org, mani@...nel.org,
 palmer@...belt.com, paul.walmsley@...ive.com, robh@...nel.org,
 s-vadapalli@...com, tglx@...utronix.de, thomas.richard@...tlin.com,
 sycamoremoon376@...il.com, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
 linux-riscv@...ts.infradead.org, sophgo@...ts.linux.dev,
 rabenda.cn@...il.com, chao.wei@...hgo.com, xiaoguang.xing@...hgo.com,
 fengchun.li@...hgo.com
Subject: Re: [PATCH v2 3/7] PCI: sg2042: Add Sophgo SG2042 PCIe driver


On 9/10/2025 10:56 AM, Inochi Amaoto wrote:
> On Wed, Sep 10, 2025 at 10:08:39AM +0800, Chen Wang wrote:

[......]

>> +static void sg2042_pcie_remove(struct platform_device *pdev)
>> +{
>> +	struct cdns_pcie *pcie = platform_get_drvdata(pdev);
>> +
>> +	cdns_pcie_disable_phy(pcie);
>> +}
>> +
> I think this remove is useless, as it is almost impossible to
> remove a pcie at runtime.

I think since we implemented the driver as a module, supporting remove 
is also a requirement for completeness. So I add this as per request 
from Manivannan in the last review.

Thanks，

Chen

> Regards,
> Inochi