linux-kernel - Re: [PATCH 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZzqRo9LRkF8=BSDANweWd0ccWtu5_nznDUn_FS6Fb0BQ@mail.gmail.com>
Date: Wed, 10 Sep 2025 23:50:57 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Gary Yang <gary.yang@...tech.com>
Cc: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>, 
	"conor+dt@...nel.org" <conor+dt@...nel.org>, 
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	cix-kernel-upstream <cix-kernel-upstream@...tech.com>
Subject: Re: [PATCH 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl

Hi Gary!

On Tue, Sep 9, 2025 at 5:30 AM Gary Yang <gary.yang@...tech.com> wrote:

> First share a good news with you. It's that We have verified the new scheme pass on Radax O6 board.

That's great!

> We just have a question before submit new patchs. As you know, there are some macros defines in dts/dtsi file.
>
> Where should these defines locate? We found these defines locate in include/dt-bindings/pinctrl/
>
> mt7623-pinfunc.h on MT7623 platform. We don't find arch/arm64/boot/dts/*/* -pinmux-props.dtsi.
>
> What's your suggestion? Please kindly remind me if I misunderstand and miss anything.

Yes these are old habits from Mediatek platforms which are bad.

Since they are not bindings, just convenience defines, I would suggest you move
the stuff from
include/dt-bindings/pinctrl/pads-sky1.h

Into
arch/arm64/boot/dts/cix/pads-sky1[.h|.dtsi]

I am not aware that using .h or .dtsi has any semantic difference,
maybe the DT experts can tell. Maybe use pads-sky1.h to be on
the safe side.

Yours,
Linus Walleij