linux-kernel - 回复: [PATCH 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PUZPR06MB588739911F77623C32AEACCAEF09A@PUZPR06MB5887.apcprd06.prod.outlook.com>
Date: Thu, 11 Sep 2025 01:58:40 +0000
From: Gary Yang <gary.yang@...tech.com>
To: Linus Walleij <linus.walleij@...aro.org>
CC: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	cix-kernel-upstream <cix-kernel-upstream@...tech.com>
Subject:
 回复: [PATCH 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl

Hi Linus,

> On Tue, Sep 9, 2025 at 5:30 AM Gary Yang <gary.yang@...tech.com> wrote:
> 
> > First share a good news with you. It's that We have verified the new scheme
> pass on Radax O6 board.
> 
> That's great!
> 
> > We just have a question before submit new patchs. As you know, there are
> some macros defines in dts/dtsi file.
> >
> > Where should these defines locate? We found these defines locate in
> > include/dt-bindings/pinctrl/
> >
> > mt7623-pinfunc.h on MT7623 platform. We don't find
> arch/arm64/boot/dts/*/* -pinmux-props.dtsi.
> >
> > What's your suggestion? Please kindly remind me if I misunderstand and
> miss anything.
> 
> Yes these are old habits from Mediatek platforms which are bad.
> 
> Since they are not bindings, just convenience defines, I would suggest you
> move the stuff from include/dt-bindings/pinctrl/pads-sky1.h
> 
> Into
> arch/arm64/boot/dts/cix/pads-sky1[.h|.dtsi]
> 
> I am not aware that using .h or .dtsi has any semantic difference, maybe the
> DT experts can tell. Maybe use pads-sky1.h to be on the safe side.
> 

Yes, I understand your thinking now. we also find some examples under arch/arm64/boot/dts/*/*.h.

for example: arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h and arch/arm64/boot/dts/mediatek/mt8516-pinfunc.h

We will take them as example, and create arch/arm64/boot/dts/cix/sky1-pinfunc.h. All right?

Thanks for your suggestion.

If miss any information, please kindly remind me.

> Yours,
> Linus Walleij

Best wishes
Gary