linux-kernel - Re: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jz26ah1w.fsf@yellow.woof>
Date: Wed, 10 Sep 2025 09:43:39 +0200
From: Nam Cao <namcao@...utronix.de>
To: Gabriele Monaco <gmonaco@...hat.com>, schuster.simon@...mens-energy.com,
 Steven Rostedt <rostedt@...dmis.org>, Christian Brauner
 <brauner@...nel.org>, Stephen Rothwell <sfr@...b.auug.org.au>
Cc: David Hildenbrand <david@...hat.com>, Lorenzo Stoakes
 <lorenzo.stoakes@...cle.com>, Arnd Bergmann <arnd@...db.de>,
 linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org, kernel
 test robot <lkp@...el.com>
Subject: Re: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64
 clone_flags

Gabriele Monaco <gmonaco@...hat.com> writes:
> On Thu, 2025-09-04 at 13:36 +0200, Simon Schuster via B4 Relay wrote:
>> From: Simon Schuster <schuster.simon@...mens-energy.com>
>> 
>> Since commit edd3cb05c00a ("copy_process: pass clone_flags as u64
>> across
>> calltree") the task_newtask trace event exposes clone_flags as u64 to
>> its callbacks.
>> 
>> However, ltl_monitor was not adapted, resulting in a faulty callback.
>> This also resulted in an lkp build warning due to
>> -Wincompatible-pointer-types.
>> 
>
> Looks good to me, thanks!
>
> Reviewed-by: Gabriele Monaco <gmonaco@...hat.com>
>
> Adding Nam (author of LTL) to the loop.

Acked-by: Nam Cao <namcao@...utronix.de>

I see no problem merging this to vfs, if vfs folks want that.

Nam