linux-kernel - Re: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b1fb5c2-3d36-4fa4-95b0-02c693933228@redhat.com>
Date: Wed, 10 Sep 2025 10:05:31 +0200
From: David Hildenbrand <david@...hat.com>
To: schuster.simon@...mens-energy.com, Steven Rostedt <rostedt@...dmis.org>,
 Christian Brauner <brauner@...nel.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Arnd Bergmann <arnd@...db.de>, linux-trace-kernel@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64
 clone_flags

On 04.09.25 13:36, Simon Schuster via B4 Relay wrote:
> From: Simon Schuster <schuster.simon@...mens-energy.com>
> 
> Since commit edd3cb05c00a ("copy_process: pass clone_flags as u64 across
> calltree") the task_newtask trace event exposes clone_flags as u64 to
> its callbacks.
> 
> However, ltl_monitor was not adapted, resulting in a faulty callback.
> This also resulted in an lkp build warning due to
> -Wincompatible-pointer-types.
> 
> Fixes: edd3cb05c00a ("copy_process: pass clone_flags as u64 across calltree")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/lkml/20250904113334.18822d43@canb.auug.org.au/
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202509040134.bQVbm7ja-lkp@intel.com/
> Signed-off-by: Simon Schuster <schuster.simon@...mens-energy.com>
> ---
> I did further search for other in-tree users of the task_newtask
> callback, but the trace macros make it a bit harder. Yet, as far as I
> could see, there are none, so this patch hopefully resolves the problem
> for good. The other matches all relate to "tp_btf/task_newtask", which
> seems to be unaffected.
> 
> With this patch, ARCH=S390 allmodconfig -- that originally tripped the
> LKP builds -- now builds without further -Wincompatible-pointer-types
> warnings.
> 
> Sorry for causing this trouble, and thanks to Stephen Rothwell for
> testing/reporting.
> ---

Not a stable commit id I think, so it should be squashed into the 
original one.

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers

David / dhildenb