[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7ef2071a-0c57-4ca8-af67-ed254d5d2faf@ti.com>
Date: Wed, 10 Sep 2025 14:29:18 +0530
From: Harikrishna Shenoy <h-shenoy@...com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
CC: <andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>, <rfoss@...nel.org>,
<Laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
<jernej.skrabec@...il.com>, <maarten.lankhorst@...ux.intel.com>,
<mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
<simona@...ll.ch>, <lumag@...nel.org>, <dianders@...omium.org>,
<andy.yan@...k-chips.com>, <mordan@...ras.ru>, <linux@...blig.org>,
<viro@...iv.linux.org.uk>, <aradhya.bhatia@...ux.dev>,
<javierm@...hat.com>, <tomi.valkeinen@...asonboard.com>,
<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
<devarsht@...com>, <u-kumar1@...com>, <s-jain1@...com>,
<lyude@...hat.com>, <luca.ceresoli@...tlin.com>
Subject: Re: [PATCH v6 1/6] drm/bridge: cadence: cdns-mhdp8546-core: Remove
legacy support for connector initialisation in bridge
On 9/9/25 19:39, Dmitry Baryshkov wrote:
> On Tue, Sep 09, 2025 at 02:38:19PM +0530, Harikrishna Shenoy wrote:
>> From: Jayesh Choudhary <j-choudhary@...com>
>>
>> Now that we have DBANC framework, remove the connector initialisation code
>> as that piece of code is not called if DRM_BRIDGE_ATTACH_NO_CONNECTOR flag
>> is used. Only TI K3 platforms consume this driver and tidss (their display
>> controller) has this flag set. So this legacy support can be dropped.
>>
>> Fixes: c932ced6b585 ("drm/tidss: Update encoder/bridge chain connect model")
> I'm not sure, why do you have this Fixes tag. Other than that:
>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
>
>
Hi Dmitry,
Have explained about fixes tag in cover letter, that these 4 commits
fix the bug of null pointer de-refernce (logs and bug described in cover
letter).
also have given the rationale of sequencing of commits in cover letter.
Warm Regards,
Hari
>> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
>> ---
>> .../drm/bridge/cadence/cdns-mhdp8546-core.c | 187 +-----------------
>> 1 file changed, 10 insertions(+), 177 deletions(-)
>>
Powered by blists - more mailing lists