linux-kernel - Re: [PATCH v3 5/9] memory: tegra210: Support interconnect framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1b0bffe-f5d4-4d71-bfb6-b047d3d2866e@kernel.org>
Date: Wed, 10 Sep 2025 12:06:58 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: webgeek1234@...il.com, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 MyungJoo Ham <myungjoo.ham@...sung.com>,
 Kyungmin Park <kyungmin.park@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>, Dmitry Osipenko <digetx@...il.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-tegra@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 5/9] memory: tegra210: Support interconnect framework

On 10/09/2025 11:39, Krzysztof Kozlowski wrote:
> On 06/09/2025 22:16, Aaron Kling via B4 Relay wrote:
>> +
>> +static int tegra_emc_interconnect_init(struct tegra210_emc *emc)
>> +{
>> +	const struct tegra_mc_soc *soc = emc->mc->soc;
>> +	struct icc_node *node;
>> +	int err;
>> +
>> +	emc->icc_provider.dev = emc->dev;
>> +	emc->icc_provider.set = emc_icc_set;
>> +	emc->icc_provider.data = &emc->icc_provider;
>> +	emc->icc_provider.aggregate = soc->icc_ops->aggregate;
>> +	emc->icc_provider.xlate_extended = emc_of_icc_xlate_extended;
>> +	emc->icc_provider.get_bw = tegra_emc_icc_get_init_bw;
>> +
>> +	icc_provider_init(&emc->icc_provider);
>> +
>> +	/* create External Memory Controller node */
>> +	node = icc_node_create(TEGRA_ICC_EMC);
>> +	if (IS_ERR(node)) {
>> +		err = PTR_ERR(node);
>> +		goto err_msg;
> 
> return dev_err_probe


I will send patches to fix existing code. I also found some more issues
which I would like to implement here.

I apologize for coming with all this at v3. I should point out things a
bit earlier, although how this patchset was organized also affected review.

Anyway my comments are mostly non-critical things, so v3 is late to
bring these, I understand. That's on me. I appreciate your work and
please do not get discouraged with my comments.

Best regards,
Krzysztof