linux-kernel - Re: [PATCH v3 5/9] memory: tegra210: Support interconnect framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALHNRZ9G_OA0+quNP=NwnwX43iaV1JWxjJFM0Aoect9Y8jGjWw@mail.gmail.com>
Date: Mon, 15 Sep 2025 01:08:15 -0500
From: Aaron Kling <webgeek1234@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, MyungJoo Ham <myungjoo.ham@...sung.com>, 
	Kyungmin Park <kyungmin.park@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>, 
	Dmitry Osipenko <digetx@...il.com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-tegra@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 5/9] memory: tegra210: Support interconnect framework

On Wed, Sep 10, 2025 at 5:07 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 10/09/2025 11:39, Krzysztof Kozlowski wrote:
> > On 06/09/2025 22:16, Aaron Kling via B4 Relay wrote:
> >> +
> >> +static int tegra_emc_interconnect_init(struct tegra210_emc *emc)
> >> +{
> >> +    const struct tegra_mc_soc *soc = emc->mc->soc;
> >> +    struct icc_node *node;
> >> +    int err;
> >> +
> >> +    emc->icc_provider.dev = emc->dev;
> >> +    emc->icc_provider.set = emc_icc_set;
> >> +    emc->icc_provider.data = &emc->icc_provider;
> >> +    emc->icc_provider.aggregate = soc->icc_ops->aggregate;
> >> +    emc->icc_provider.xlate_extended = emc_of_icc_xlate_extended;
> >> +    emc->icc_provider.get_bw = tegra_emc_icc_get_init_bw;
> >> +
> >> +    icc_provider_init(&emc->icc_provider);
> >> +
> >> +    /* create External Memory Controller node */
> >> +    node = icc_node_create(TEGRA_ICC_EMC);
> >> +    if (IS_ERR(node)) {
> >> +            err = PTR_ERR(node);
> >> +            goto err_msg;
> >
> > return dev_err_probe
>
>
> I will send patches to fix existing code. I also found some more issues
> which I would like to implement here.
>
> I apologize for coming with all this at v3. I should point out things a
> bit earlier, although how this patchset was organized also affected review.
>
> Anyway my comments are mostly non-critical things, so v3 is late to
> bring these, I understand. That's on me. I appreciate your work and
> please do not get discouraged with my comments.

I understand and that's fine. Get it done right the first time so it
doesn't have to be redone later. I will try to get a new revision out
this week once I cycle back around to the relevant devices here.

Aaron