| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aMFRSz9K5AkrwtMb@pengutronix.de> Date: Wed, 10 Sep 2025 12:22:03 +0200 From: Oleksij Rempel <o.rempel@...gutronix.de> To: Maxime Chevallier <maxime.chevallier@...tlin.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, thomas.petazzoni@...tlin.com, Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>, linux-arm-kernel@...ts.infradead.org, Christophe Leroy <christophe.leroy@...roup.eu>, Herve Codina <herve.codina@...tlin.com>, Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, Vladimir Oltean <vladimir.oltean@....com>, Köry Maincent <kory.maincent@...tlin.com>, Marek Behún <kabel@...nel.org>, Nicolò Veronese <nicveronese@...il.com>, Simon Horman <horms@...nel.org>, mwojtas@...omium.org, Antoine Tenart <atenart@...nel.org>, devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>, Romain Gantois <romain.gantois@...tlin.com>, Daniel Golle <daniel@...rotopia.org>, Dimitri Fedrau <dimitri.fedrau@...bherr.com> Subject: Re: [PATCH net-next v12 00/18] net: phy: Introduce PHY ports representation Hi Maxime, I tested this series on top of net-next against lan78xx. No visible regressions for existing setup: Tested-by: Oleksij Rempel <o.rempel@...gutronix.de> On Tue, Sep 09, 2025 at 05:25:56PM +0200, Maxime Chevallier wrote: > Hi everyone, > > Here is a V12 for the phy_port work, aiming at representing the > connectors and outputs of PHY devices. > > Last round was 16 patches, and now 18, if needed I can split some > patches out such as the 2 phylink ones. > > this V12 address the SFP interface selection for PHY driver SFPs, as > commented by Russell on v10. > > This and Rob's review on the dp83822 patch are the only changes. > > As a remainder, a few important notes : > > - This is only a first phase. It instantiates the port, and leverage > that to make the MAC <-> PHY <-> SFP usecase simpler. > > - Next phase will deal with controlling the port state, as well as the > netlink uAPI for that. > > - The end-goal is to enable support for complex port MUX. This > preliminary work focuses on PHY-driven ports, but this will be > extended to support muxing at the MII level (Multi-phy, or compo PHY > + SFP as found on Turris Omnia for example). > > - The naming is definitely not set in stone. I named that "phy_port", > but this may convey the false sense that this is phylib-specific. > Even the word "port" is not that great, as it already has several > different meanings in the net world (switch port, devlink port, > etc.). I used the term "connector" in the binding. > > A bit of history on that work : > > The end goal that I personnaly want to achieve is : > > + PHY - RJ45 > | > MAC - MUX -+ PHY - RJ45 > > After many discussions here on netdev@, but also at netdevconf[1] and > LPC[2], there appears to be several analoguous designs that exist out > there. > > [1] : https://netdevconf.info/0x17/sessions/talk/improving-multi-phy-and-multi-port-interfaces.html > [2] : https://lpc.events/event/18/contributions/1964/ (video isn't the > right one) > > Take the MAchiatobin, it has 2 interfaces that looks like this : > > MAC - PHY -+ RJ45 > | > + SFP - Whatever the module does > > Now, looking at the Turris Omnia, we have : > > > MAC - MUX -+ PHY - RJ45 > | > + SFP - Whatever the module does > > We can find more example of this kind of designs, the common part is > that we expose multiple front-facing media ports. This is what this > current work aims at supporting. As of right now, it does'nt add any > support for muxing, but this will come later on. > > This first phase focuses on phy-driven ports only, but there are already > quite some challenges already. For one, we can't really autodetect how > many ports are sitting behind a PHY. That's why this series introduces a > new binding. Describing ports in DT should however be a last-resort > thing when we need to clear some ambiguity about the PHY media-side. > > The only use-cases that we have today for multi-port PHYs are combo PHYs > that drive both a Copper port and an SFP (the Macchiatobin case). This > in itself is challenging and this series only addresses part of this > support, by registering a phy_port for the PHY <-> SFP connection. The > SFP module should in the end be considered as a port as well, but that's > not yet the case. > > However, because now PHYs can register phy_ports for every media-side > interface they have, they can register the capabilities of their ports, > which allows making the PHY-driver SFP case much more generic. > > Let me know what you think, I'm all in for discussions :) > > Regards, > > Changes in V12: > - Moved some of phylink's internal helpers to phy_caps for reuse in > phylib > - Fixed SFP interface selection > - Added Rob's review and changes in patch 6 > > Changes in V11: > - The ti,fiber-mode property was deprecated in favor of the > ethernet-connector binding > - The .attach_port was split into an MDI and an MII version > - I added the warning back in the AR8031 PHY driver > - There is now an init-time check on the number of lanes associated to > every linkmode, making sure the number of lanes is above or equal to > the minimum required > - Various typos were fixed all around > - We no longer use sfp_select_interface() for SFP interface validation > > Changes in V10: > - Rebase on net-next > - Fix a typo reported by Köry > - Aggregate all reviews > - Fix the conflict on the qcom driver > > Changes in V9: > - Removed maxItems and items from the connector binding > - Fixed a typo in the binding > > Changes in V8: > - Added maxItems on the connector media binding > - Made sure we parse a single medium > - Added a missing bitwise macro > > Changes in V7: > - Move ethtool_medium_get_supported to phy_caps > - support combo-ports, each with a given set of supported modes > - Introduce the notion of 'not-described' ports > > Changes in V6: > > - Fixed kdoc on patch 3 > - Addressed a missing port-ops registration for the Marvell 88x2222 > driver > - Addressed a warning reported by Simon on the DP83822 when building > without CONFIG_OF_MDIO > > Changes in V5 : > > - renamed the bindings to use the term "connector" instead of "port" > - Rebased, and fixed some issues reported on the 83822 driver > - Use phy_caps > > Changes in V4 : > > - Introduced a kernel doc > - Reworked the mediums definitions in patch 2 > - QCA807x now uses the generic SFP support > - Fixed some implementation bugs to build the support list based on the > interfaces supported on a port > > V11:https://lore.kernel.org/netdev/20250814135832.174911-1-maxime.chevallier@bootlin.com/ > V10: https://lore.kernel.org/netdev/20250722121623.609732-1-maxime.chevallier@bootlin.com/ > V9: https://lore.kernel.org/netdev/20250717073020.154010-1-maxime.chevallier@bootlin.com/ > V8: https://lore.kernel.org/netdev/20250710134533.596123-1-maxime.chevallier@bootlin.com/ > v7: https://lore.kernel.org/netdev/20250630143315.250879-1-maxime.chevallier@bootlin.com/ > V6: https://lore.kernel.org/netdev/20250507135331.76021-1-maxime.chevallier@bootlin.com/ > V5: https://lore.kernel.org/netdev/20250425141511.182537-1-maxime.chevallier@bootlin.com/ > V4: https://lore.kernel.org/netdev/20250213101606.1154014-1-maxime.chevallier@bootlin.com/ > V3: https://lore.kernel.org/netdev/20250207223634.600218-1-maxime.chevallier@bootlin.com/ > RFC V2: https://lore.kernel.org/netdev/20250122174252.82730-1-maxime.chevallier@bootlin.com/ > RFC V1: https://lore.kernel.org/netdev/20241220201506.2791940-1-maxime.chevallier@bootlin.com/ > > Maxime > > Maxime Chevallier (18): > dt-bindings: net: Introduce the ethernet-connector description > net: ethtool: common: Indicate that BaseT works on up to 4 lanes > net: ethtool: Introduce ETHTOOL_LINK_MEDIUM_* values > net: phy: Introduce PHY ports representation > net: phy: dp83822: Add support for phy_port representation > dt-bindings: net: dp83822: Deprecate ti,fiber-mode > net: phy: Create a phy_port for PHY-driven SFPs > net: phylink: Move phylink_interface_max_speed to phy_caps > net: phylink: Move sfp interface selection and filtering to phy_caps > net: phy: Introduce generic SFP handling for PHY drivers > net: phy: marvell-88x2222: Support SFP through phy_port interface > net: phy: marvell: Support SFP through phy_port interface > net: phy: marvell10g: Support SFP through phy_port > net: phy: at803x: Support SFP through phy_port interface > net: phy: qca807x: Support SFP through phy_port interface > net: phy: Only rely on phy_port for PHY-driven SFP > net: phy: dp83822: Add SFP support through the phy_port interface > Documentation: networking: Document the phy_port infrastructure > > .../bindings/net/ethernet-connector.yaml | 45 +++ > .../devicetree/bindings/net/ethernet-phy.yaml | 18 + > .../devicetree/bindings/net/ti,dp83822.yaml | 10 +- > Documentation/networking/index.rst | 1 + > Documentation/networking/phy-port.rst | 111 ++++++ > MAINTAINERS | 3 + > drivers/net/phy/Makefile | 2 +- > drivers/net/phy/dp83822.c | 79 +++-- > drivers/net/phy/marvell-88x2222.c | 95 ++--- > drivers/net/phy/marvell.c | 94 ++--- > drivers/net/phy/marvell10g.c | 54 +-- > drivers/net/phy/phy-caps.h | 12 + > drivers/net/phy/phy-core.c | 6 + > drivers/net/phy/phy_caps.c | 216 +++++++++++ > drivers/net/phy/phy_device.c | 334 +++++++++++++++++- > drivers/net/phy/phy_port.c | 194 ++++++++++ > drivers/net/phy/phylink.c | 157 +------- > drivers/net/phy/qcom/at803x.c | 78 ++-- > drivers/net/phy/qcom/qca807x.c | 73 ++-- > include/linux/ethtool.h | 44 ++- > include/linux/phy.h | 63 +++- > include/linux/phy_port.h | 99 ++++++ > include/uapi/linux/ethtool.h | 20 ++ > net/ethtool/common.c | 267 ++++++++------ > 24 files changed, 1541 insertions(+), 534 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/ethernet-connector.yaml > create mode 100644 Documentation/networking/phy-port.rst > create mode 100644 drivers/net/phy/phy_port.c > create mode 100644 include/linux/phy_port.h > > -- > 2.49.0 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists