linux-kernel - Re: [PATCH v2 1/2] drm/i915: set O_LARGEFILE in __create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tencent_EA6C39EF0B78D46EA32051C7151E859A2F08@qq.com>
Date: Wed, 10 Sep 2025 18:41:21 +0800
From: Taotao Chen <chentao325@...com>
To: "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>,
 "joonas.lahtinen@...ux.intel.com" <joonas.lahtinen@...ux.intel.com>,
 "rodrigo.vivi@...el.com" <rodrigo.vivi@...el.com>,
 "tursulin@...ulin.net" <tursulin@...ulin.net>,
 "andi.shyti@...ux.intel.com" <andi.shyti@...ux.intel.com>
Cc: "airlied@...il.com" <airlied@...il.com>, "daniel@...ll.ch"
 <daniel@...ll.ch>,
 "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 kernel test robot <oliver.sang@...el.com>,
 chentaotao <chentaotao@...iglobal.com>
Subject: Re: [PATCH v2 1/2] drm/i915: set O_LARGEFILE in __create_shmem()


在 2025/8/22 11:06, 陈涛涛 Taotao Chen 写道:
> From: Taotao Chen <chentaotao@...iglobal.com>
>
> Without O_LARGEFILE, file->f_op->write_iter calls
> generic_write_check_limits(), which enforces a 2GB (MAX_NON_LFS) limit,
> causing -EFBIG on large writes.
>
> In shmem_pwrite(), this error is later masked as -EIO due to the error
> handling order, leading to igt failures like gen9_exec_parse(bb-large).
>
> Set O_LARGEFILE in __create_shmem() to prevent -EFBIG on large writes.
>
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202508081029.343192ec-lkp@intel.com
> Fixes: 048832a3f400 ("drm/i915: Refactor shmem_pwrite() to use kiocb and write_iter")
> Signed-off-by: Taotao Chen <chentaotao@...iglobal.com>
> ---
> v2:
>   - Add force_o_largefile() guard before setting O_LARGEFILE
>
>   drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> index e3d188455f67..b9dae15c1d16 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> @@ -514,6 +514,13 @@ static int __create_shmem(struct drm_i915_private *i915,
>   	if (IS_ERR(filp))
>   		return PTR_ERR(filp);
>   
> +	/*
> +	 * Prevent -EFBIG by allowing large writes beyond MAX_NON_LFS on shmem
> +	 * objects by setting O_LARGEFILE.
> +	 */
> +	if (force_o_largefile())
> +		filp->f_flags |= O_LARGEFILE;
> +
>   	obj->filp = filp;
>   	return 0;
>   }

Hi,

Just a gentle ping on this patch. Any further comments or plans to pick 
it up?

Thanks,
Taotao