linux-kernel - Re: [PATCH v2 1/2] drm/i915: set O_LARGEFILE in __create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eijc4lnkdfsk6l4go2psyt4g6ufrha7sijeearcvuo7nqrbkby@kqod2veuvaco>
Date: Mon, 15 Sep 2025 14:03:56 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Taotao Chen <chentao325@...com>
Cc: "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>, 
	"joonas.lahtinen@...ux.intel.com" <joonas.lahtinen@...ux.intel.com>, "rodrigo.vivi@...el.com" <rodrigo.vivi@...el.com>, 
	"tursulin@...ulin.net" <tursulin@...ulin.net>, "andi.shyti@...ux.intel.com" <andi.shyti@...ux.intel.com>, 
	"airlied@...il.com" <airlied@...il.com>, "daniel@...ll.ch" <daniel@...ll.ch>, 
	"intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>, 
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	kernel test robot <oliver.sang@...el.com>, chentaotao <chentaotao@...iglobal.com>
Subject: Re: [PATCH v2 1/2] drm/i915: set O_LARGEFILE in __create_shmem()

Hi Taotao,

> > Without O_LARGEFILE, file->f_op->write_iter calls
> > generic_write_check_limits(), which enforces a 2GB (MAX_NON_LFS) limit,
> > causing -EFBIG on large writes.
> > 
> > In shmem_pwrite(), this error is later masked as -EIO due to the error
> > handling order, leading to igt failures like gen9_exec_parse(bb-large).
> > 
> > Set O_LARGEFILE in __create_shmem() to prevent -EFBIG on large writes.
> > 
> > Reported-by: kernel test robot <oliver.sang@...el.com>
> > Closes: https://lore.kernel.org/oe-lkp/202508081029.343192ec-lkp@intel.com
> > Fixes: 048832a3f400 ("drm/i915: Refactor shmem_pwrite() to use kiocb and write_iter")
> > Signed-off-by: Taotao Chen <chentaotao@...iglobal.com>

...

> Just a gentle ping on this patch. Any further comments or plans to pick it
> up?

Unfortunately your patch has not been picked up by our CI, now I
re-run the test.

In any case, your second patch can't be merged yet because your
previous one(*) has been applied to the wrong branch from
Christian while it should have gone through drm-intel-gt-next.
Now we need to wait for a backmerge.

In any case, if the tests succeed, I can already apply your first
patch so that it gets included in the Wednesday's pull request.

While the second patch, that is not a fix, has plenty of time and
can wait the backmerge.

Andi

(*) 048832a3f400 ("drm/i915: Refactor shmem_pwrite() to use kiocb and write_iter")