linux-kernel - Re: [PATCH] ACPI: SPCR: Add support for DBG2 RISC-V SBI port subtype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJF2gTTiBkNGAu92OrzoHLUgSrs1E7xPjkA3hmFRvngApn5enw@mail.gmail.com>
Date: Thu, 11 Sep 2025 10:17:47 +0800
From: Guo Ren <guoren@...nel.org>
To: cp0613@...ux.alibaba.com
Cc: rafael@...nel.org, lenb@...nel.org, jeeheng.sia@...rfivetech.com, 
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: SPCR: Add support for DBG2 RISC-V SBI port subtype

On Wed, Sep 10, 2025 at 5:42 PM <cp0613@...ux.alibaba.com> wrote:
>
> From: Chen Pei <cp0613@...ux.alibaba.com>
>
> The commit 4aca2bef90bd1296 ("ACPICA: Headers: Add RISC-V SBI Subtype
> to DBG2") has added the definition of ACPI_DBG2_RISCV_SBI_CON.
>
> This patch continues to implement its function so that the parameters
> of uart can be configured correctly. Subsequent calls to setup_earlycon
> to reuse the earlycon based on sbi.
>
> Signed-off-by: Chen Pei <cp0613@...ux.alibaba.com>
> ---
>  drivers/acpi/spcr.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
> index cd36a97b0ea2..208d6bbc65e0 100644
> --- a/drivers/acpi/spcr.c
> +++ b/drivers/acpi/spcr.c
> @@ -141,6 +141,9 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
>         case ACPI_DBG2_16550_NVIDIA:
>                 uart = "uart";
>                 break;
> +       case ACPI_DBG2_RISCV_SBI_CON:
> +               uart = "sbi";
> +               break;
Yes, SPCR lacks ACPI_DBG2_RISCV_SBI_CON, and ACPICA has adopted it.
So, it's time to add ACPI_DBG2_RISCV_SBI_CON support in spcr.c. It
would solve the UEFI + ACPI early debug problem.

LGTM!

Reviewed-by: Guo Ren (Alibaba Damo Academy) <guoren@...nel.org>

>         default:
>                 err = -ENOENT;
>                 goto done;
> --
> 2.49.0
>


-- 
Best Regards
 Guo Ren