linux-kernel - Re: [PATCH v2 1/2] ASoC: dt-bindings: ti,pcm1754: add binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250911-whimsical-speedy-pigeon-b85014@kuoka>
Date: Thu, 11 Sep 2025 09:38:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stefan Kerkmann <s.kerkmann@...gutronix.de>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	Alvin Šipraga <alvin@...s.dk>, linux-sound@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: ti,pcm1754: add binding
 documentation

On Wed, Sep 10, 2025 at 11:34:05AM +0200, Stefan Kerkmann wrote:
> +  vcc-supply: true
> +
> +  '#sound-dai-cells':
> +    const: 0
> +
> +  format-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO used to select the PCM format
> +
> +  mute-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO used to mute all outputs
> +
> +required:
> +  - compatible
> +  - '#sound-dai-cells'
> +  - vcc-supply

If there is going to be a new version then:

Keep same order as in properties, so supply before cells.

> +
> +additionalProperties: false

and this should be probably unevaluatedProperties: false.

Regardless,

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof