[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250911-uppish-tarsier-of-kindness-fbb138@kuoka>
Date: Thu, 11 Sep 2025 09:39:36 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stefan Kerkmann <s.kerkmann@...gutronix.de>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
Alvin Šipraga <alvin@...s.dk>, linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: ti,pcm1754: add binding
documentation
On Wed, Sep 10, 2025 at 11:34:05AM +0200, Stefan Kerkmann wrote:
> The Texas Instruments PCM1754 is a simple stereo DAC without any digital
> management interface but soft mute, PCM input format and 44.1 kHz
> digital de-emphasis can be configured via strapping pins. Only soft mute
> and PCM input format selection is currently exposed via optional GPIOs
> in the driver.
Ah, and if you resend for any reason, then:
A nit, subject: drop second/last, redundant "binding documentation". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Instead: "add TI PCM1754 Stereo DAC"
Best regards,
Krzysztof
Powered by blists - more mailing lists