linux-kernel - Re: [PATCH v2] mtd: core: always verify OOB offset in mtd_check_oob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87348tbeqg.fsf@bootlin.com>
Date: Thu, 11 Sep 2025 10:00:39 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Santhosh Kumar K <s-k6@...com>
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  Gabor Juhos <j4g8y7@...il.com>,
  <linux-mtd@...ts.infradead.org>,  <linux-kernel@...r.kernel.org>,
  <stable@...r.kernel.org>,  Daniel Golle <daniel@...rotopia.org>
Subject: Re: [PATCH v2] mtd: core: always verify OOB offset in
 mtd_check_oob_ops()

Hello,

On 11/09/2025 at 11:52:27 +0530, Santhosh Kumar K <s-k6@...com> wrote:

> Hello,
>
> On 05/09/25 20:25, Miquel Raynal wrote:
>> On Mon, 01 Sep 2025 16:24:35 +0200, Gabor Juhos wrote:
>>> Using an OOB offset past end of the available OOB data is invalid,
>>> irregardless of whether the 'ooblen' is set in the ops or not. Move
>>> the relevant check out from the if statement to always verify that.
>>>
>>> The 'oobtest' module executes four tests to verify how reading/writing
>>> OOB data past end of the devices is handled. It expects errors in case
>>> of these tests, but this expectation fails in the last two tests on
>>> MTD devices, which have no OOB bytes available.
>>>
>>> [...]
>> Applied to mtd/next, thanks!
>> [1/1] mtd: core: always verify OOB offset in mtd_check_oob_ops()
>>        commit: bf7d0543b2602be5cb450d8ec5a8710787806f88
>
> I'm seeing a failure in SPI NOR flashes due to this patch:
> (Tested on AM62x SK with S28HS512T OSPI NOR flash)

Gabor, can you check what happens with mtdblock? Otherwise this will
need to be reverted.

Thanks,
Miquèl