linux-kernel - RE: [PATCH v2 6/6] remoteproc: imx_rproc: Clean up after ops introduction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8459CABA152B6C1C122B35F28809A@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Thu, 11 Sep 2025 01:13:59 +0000
From: Peng Fan <peng.fan@....com>
To: Frank Li <frank.li@....com>
CC: Bjorn Andersson <andersson@...nel.org>, Mathieu Poirier
	<mathieu.poirier@...aro.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
	<s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, Daniel Baluta <daniel.baluta@....com>,
	Hiago De Franco <hiago.franco@...adex.com>,
	"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 6/6] remoteproc: imx_rproc: Clean up after ops
 introduction

Hi Frank,

> Subject: Re: [PATCH v2 6/6] remoteproc: imx_rproc: Clean up after ops
> introduction
> >
> > -	if (dcfg->ops && dcfg->ops->detect_mode)
> > -		return dcfg->ops->detect_mode(priv->rproc);
> > -
> > -	switch (dcfg->method) {
> 
> Can you remove 'method' in data struct also?

The method is used in other places and other purpose, imx_rproc_detach
imx_rproc_put_scu, imx_rproc_remove, it is also referred 
imx_dsp_rproc.c.

Could we keep it for now?

Thanks,
Peng.

> 
> Frank
> > -	case IMX_RPROC_NONE:
> > +	/*
> > +	 * To i.MX{7,8} ULP, Linux is under control of RTOS, no need
> > +	 * dcfg->ops or dcfg->ops->detect_mode, it is state
> RPROC_DETACHED.
> > +	 */
> > +	if (!dcfg->ops || !dcfg->ops->detect_mode) {
> >  		priv->rproc->state = RPROC_DETACHED;
> >  		return 0;
> > -	default:
> > -		break;
> >  	}
> >
> > -	return 0;
> > +	return dcfg->ops->detect_mode(priv->rproc);
> >  }
> >
> >  static int imx_rproc_clk_enable(struct imx_rproc *priv)
> >
> > --
> > 2.37.1
> >