linux-kernel - Re: [PATCH v2 6/6] remoteproc: imx_rproc: Clean up after ops introduction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250912061120.GA27864@nxa18884-linux.ap.freescale.net>
Date: Fri, 12 Sep 2025 14:11:20 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Peng Fan <peng.fan@....com>, Frank Li <frank.li@....com>,
	Bjorn Andersson <andersson@...nel.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>
Cc: Frank Li <frank.li@....com>, Bjorn Andersson <andersson@...nel.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Daniel Baluta <daniel.baluta@....com>,
	Hiago De Franco <hiago.franco@...adex.com>,
	"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 6/6] remoteproc: imx_rproc: Clean up after ops
 introduction

On Thu, Sep 11, 2025 at 01:13:59AM +0000, Peng Fan wrote:
>Hi Frank,
>> 
>> Can you remove 'method' in data struct also?
>
>The method is used in other places and other purpose, imx_rproc_detach
>imx_rproc_put_scu, imx_rproc_remove, it is also referred 
>imx_dsp_rproc.c.
>
>Could we keep it for now?

The method could not be removed from the data structure, because it is also
used in imx_dsp_rproc.c.

I have a few more patches to do further cleanup, but that would make
the patchset a bit larger. I would like to see Mathieu's view.

Mathieu,

Do you expect me to add more patches in V3 to cleanup other parts or
we could keep the patchset size as it is, with further cleanup in
a standalone new patchset?

Thanks,
Peng.


>
>Thanks,
>Peng.
>
>> 
>> Frank
>> > -	case IMX_RPROC_NONE:
>> > +	/*
>> > +	 * To i.MX{7,8} ULP, Linux is under control of RTOS, no need
>> > +	 * dcfg->ops or dcfg->ops->detect_mode, it is state
>> RPROC_DETACHED.
>> > +	 */
>> > +	if (!dcfg->ops || !dcfg->ops->detect_mode) {
>> >  		priv->rproc->state = RPROC_DETACHED;
>> >  		return 0;
>> > -	default:
>> > -		break;
>> >  	}
>> >
>> > -	return 0;
>> > +	return dcfg->ops->detect_mode(priv->rproc);
>> >  }
>> >
>> >  static int imx_rproc_clk_enable(struct imx_rproc *priv)
>> >
>> > --
>> > 2.37.1
>> >