linux-kernel - Re: [PATCH v1] cpufreq: ACPI: Use on_each_cpu_mask() in drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hX6v7Zn7_mbdNWQg-muMbfz1HDA8pp1eg7Lfpx=UZjww@mail.gmail.com>
Date: Thu, 11 Sep 2025 11:01:36 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Mario Limonciello <superm1@...nel.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Linux PM <linux-pm@...r.kernel.org>, 
	LKML <linux-kernel@...r.kernel.org>, Linux ACPI <linux-acpi@...r.kernel.org>, 
	Viresh Kumar <viresh.kumar@...aro.org>, "Gautham R . Shenoy" <gautham.sheoy@....com>
Subject: Re: [PATCH v1] cpufreq: ACPI: Use on_each_cpu_mask() in drv_write()

On Wed, Sep 10, 2025 at 10:38 PM Mario Limonciello <superm1@...nel.org> wrote:
>
> On 9/9/25 6:41 AM, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> >
> > Make drv_write() call on_each_cpu_mask() instead of using an open-coded
> > equivalent of the latter.
> >
> > No intentional functional impact.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > ---
>
> I feel you should also update the comment before do_drv_write() to
> mention it's called with a NULL conditional to
> smp_call_function_many_cond(), or just drop that comment.

I'll drop it.

> Reviewed-by: Mario Limonciello (AMD) <superm1@...nel.org>

Thanks!

> >   drivers/cpufreq/acpi-cpufreq.c |    8 +-------
> >   1 file changed, 1 insertion(+), 7 deletions(-)
> >
> > --- a/drivers/cpufreq/acpi-cpufreq.c
> > +++ b/drivers/cpufreq/acpi-cpufreq.c
> > @@ -335,14 +335,8 @@ static void drv_write(struct acpi_cpufre
> >               .val = val,
> >               .func.write = data->cpu_freq_write,
> >       };
> > -     int this_cpu;
> >
> > -     this_cpu = get_cpu();
> > -     if (cpumask_test_cpu(this_cpu, mask))
> > -             do_drv_write(&cmd);
> > -
> > -     smp_call_function_many(mask, do_drv_write, &cmd, 1);
> > -     put_cpu();
> > +     on_each_cpu_mask(mask, do_drv_write, &cmd, true);
> >   }
> >
> >   static u32 get_cur_val(const struct cpumask *mask, struct acpi_cpufreq_data *data)
> >
> >
> >
>