linux-kernel - Re: [PATCH net-next 2/2] net: dsa: microchip: configure strap pins during reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7361bf07-892b-406f-aca5-c53a7d876ac4@microchip.com>
Date: Thu, 11 Sep 2025 10:53:41 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <bastien.curutchet@...tlin.com>, <Woojung.Huh@...rochip.com>,
	<UNGLinuxDriver@...rochip.com>, <andrew@...n.ch>, <olteanv@...il.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<conor+dt@...nel.org>, <marex@...x.de>
CC: <thomas.petazzoni@...tlin.com>, <miquel.raynal@...tlin.com>,
	<pascal.eberhard@...com>, <netdev@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: dsa: microchip: configure strap pins
 during reset

Hi,

On 10/09/25 8:25 pm, Bastien Curutchet wrote:
> diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
> index 7292bfe2f7cac3a0d88bb51339cc287f56ca1d1f..0ab201a3c336b99ba92d87c003ba48f7f82a098a 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -23,6 +23,7 @@
>   #include <linux/of_mdio.h>
>   #include <linux/of_net.h>
>   #include <linux/micrel_phy.h>
> +#include <linux/pinctrl/consumer.h>
>   #include <net/dsa.h>
>   #include <net/ieee8021q.h>
>   #include <net/pkt_cls.h>
> @@ -5338,6 +5339,44 @@ static int ksz_parse_drive_strength(struct ksz_device *dev)
>          return 0;
>   }
> 
> +static int ksz_configure_strap(struct ksz_device *dev)
> +{
> +       struct pinctrl_state *state = NULL;
I don't think you need to initialize here.
> +       struct pinctrl *pinctrl;
> +       int ret;
> +

Best regards,
Parthiban V