linux-kernel - Re: [PATCH 18/38] arm64: dts: mediatek: mt6797: Remove bogus id property in i2c nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03402a44-7025-4e31-9ead-a2ecbf63f325@gmail.com>
Date: Fri, 12 Sep 2025 16:01:12 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-mediatek@...ts.infradead.org, robh@...nel.org
Cc: herbert@...dor.apana.org.au, davem@...emloft.net, krzk+dt@...nel.org,
 conor+dt@...nel.org, chunkuang.hu@...nel.org, p.zabel@...gutronix.de,
 airlied@...il.com, simona@...ll.ch, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, jassisinghbrar@...il.com,
 mchehab@...nel.org, chunfeng.yun@...iatek.com, vkoul@...nel.org,
 kishon@...nel.org, sean.wang@...nel.org, linus.walleij@...aro.org,
 lgirdwood@...il.com, broonie@...nel.org, andersson@...nel.org,
 mathieu.poirier@...aro.org, daniel.lezcano@...aro.org, tglx@...utronix.de,
 atenart@...nel.org, jitao.shi@...iatek.com, ck.hu@...iatek.com,
 houlong.wei@...iatek.com, kyrie.wu@...iatek.corp-partner.google.com,
 andy.teng@...iatek.com, tinghan.shen@...iatek.com, jiaxin.yu@...iatek.com,
 shane.chien@...iatek.com, olivia.wen@...iatek.com, granquet@...libre.com,
 eugen.hristev@...aro.org, arnd@...db.de, sam.shih@...iatek.com,
 jieyy.yang@...iatek.com, frank-w@...lic-files.de, mwalle@...nel.org,
 fparent@...libre.com, linux-crypto@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-media@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org,
 linux-gpio@...r.kernel.org, linux-remoteproc@...r.kernel.org,
 linux-sound@...r.kernel.org
Subject: Re: [PATCH 18/38] arm64: dts: mediatek: mt6797: Remove bogus id
 property in i2c nodes



On 24/07/2025 10:38, AngeloGioacchino Del Regno wrote:
> All of the I2C nodes in this devicetree has a bogus "id" property,
> which was probably specifying the I2C bus number.
> 
> This property was never parsed and never used - and besides, it
> also gives dtbs_check warnings: remove it from all i2c nodes.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Applied, thanks

> ---
>   arch/arm64/boot/dts/mediatek/mt6797.dtsi | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt6797.dtsi b/arch/arm64/boot/dts/mediatek/mt6797.dtsi
> index be401617dfd8..f2d93bf6a055 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6797.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6797.dtsi
> @@ -285,7 +285,6 @@ uart3: serial@...05000 {
>   	i2c0: i2c@...07000 {
>   		compatible = "mediatek,mt6797-i2c",
>   			     "mediatek,mt6577-i2c";
> -		id = <0>;
>   		reg = <0 0x11007000 0 0x1000>,
>   		      <0 0x11000100 0 0x80>;
>   		interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>;
> @@ -301,7 +300,6 @@ i2c0: i2c@...07000 {
>   	i2c1: i2c@...08000 {
>   		compatible = "mediatek,mt6797-i2c",
>   			     "mediatek,mt6577-i2c";
> -		id = <1>;
>   		reg = <0 0x11008000 0 0x1000>,
>   		      <0 0x11000180 0 0x80>;
>   		interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_LOW>;
> @@ -317,7 +315,6 @@ i2c1: i2c@...08000 {
>   	i2c8: i2c@...09000 {
>   		compatible = "mediatek,mt6797-i2c",
>   			     "mediatek,mt6577-i2c";
> -		id = <8>;
>   		reg = <0 0x11009000 0 0x1000>,
>   		      <0 0x11000200 0 0x80>;
>   		interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_LOW>;
> @@ -334,7 +331,6 @@ i2c8: i2c@...09000 {
>   	i2c9: i2c@...0d000 {
>   		compatible = "mediatek,mt6797-i2c",
>   			     "mediatek,mt6577-i2c";
> -		id = <9>;
>   		reg = <0 0x1100d000 0 0x1000>,
>   		      <0 0x11000280 0 0x80>;
>   		interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_LOW>;
> @@ -351,7 +347,6 @@ i2c9: i2c@...0d000 {
>   	i2c6: i2c@...0e000 {
>   		compatible = "mediatek,mt6797-i2c",
>   			     "mediatek,mt6577-i2c";
> -		id = <6>;
>   		reg = <0 0x1100e000 0 0x1000>,
>   		      <0 0x11000500 0 0x80>;
>   		interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_LOW>;
> @@ -367,7 +362,6 @@ i2c6: i2c@...0e000 {
>   	i2c7: i2c@...10000 {
>   		compatible = "mediatek,mt6797-i2c",
>   			     "mediatek,mt6577-i2c";
> -		id = <7>;
>   		reg = <0 0x11010000 0 0x1000>,
>   		      <0 0x11000580 0 0x80>;
>   		interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_LOW>;
> @@ -383,7 +377,6 @@ i2c7: i2c@...10000 {
>   	i2c4: i2c@...11000 {
>   		compatible = "mediatek,mt6797-i2c",
>   			     "mediatek,mt6577-i2c";
> -		id = <4>;
>   		reg = <0 0x11011000 0 0x1000>,
>   		      <0 0x11000300 0 0x80>;
>   		interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_LOW>;
> @@ -399,7 +392,6 @@ i2c4: i2c@...11000 {
>   	i2c2: i2c@...13000 {
>   		compatible = "mediatek,mt6797-i2c",
>   			     "mediatek,mt6577-i2c";
> -		id = <2>;
>   		reg = <0 0x11013000 0 0x1000>,
>   		      <0 0x11000400 0 0x80>;
>   		interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_LOW>;
> @@ -416,7 +408,6 @@ i2c2: i2c@...13000 {
>   	i2c3: i2c@...14000 {
>   		compatible = "mediatek,mt6797-i2c",
>   			     "mediatek,mt6577-i2c";
> -		id = <3>;
>   		reg = <0 0x11014000 0 0x1000>,
>   		      <0 0x11000480 0 0x80>;
>   		interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_LOW>;
> @@ -433,7 +424,6 @@ i2c3: i2c@...14000 {
>   	i2c5: i2c@...1c000 {
>   		compatible = "mediatek,mt6797-i2c",
>   			     "mediatek,mt6577-i2c";
> -		id = <5>;
>   		reg = <0 0x1101c000 0 0x1000>,
>   		      <0 0x11000380 0 0x80>;
>   		interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>;