linux-kernel - Re: [PATCH] pid: use ns_capable_noaudit() when determining net sysctl permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMR2EfsdxmIXIgTW@mail.hallyn.com>
Date: Fri, 12 Sep 2025 14:35:45 -0500
From: "Serge E. Hallyn" <serge@...lyn.com>
To: "Serge E. Hallyn" <serge@...lyn.com>
Cc: Paul Moore <paul@...l-moore.com>,
	Christian Göttsche <cgoettsche@...tendoof.de>,
	linux-kernel@...r.kernel.org,
	Christian Göttsche <cgzones@...glemail.com>,
	Christian Brauner <brauner@...nel.org>,
	linux-security-module@...r.kernel.org, selinux@...r.kernel.org
Subject: Re: [PATCH] pid: use ns_capable_noaudit() when determining net
 sysctl  permissions

On Thu, Sep 11, 2025 at 06:05:05PM -0500, Serge E. Hallyn wrote:
> On Thu, Sep 11, 2025 at 04:46:20PM -0400, Paul Moore wrote:
> > On Sep 10, 2025 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgoettsche@...tendoof.de> wrote:
> > > 
> > > The capability check should not be audited since it is only being used
> > > to determine the inode permissions. A failed check does not indicate a
> > > violation of security policy but, when an LSM is enabled, a denial audit
> > > message was being generated.
> > > 
> > > The denial audit message can either lead to the capability being
> > > unnecessarily allowed in a security policy, or being silenced potentially
> > > masking a legitimate capability check at a later point in time.
> > > 
> > > Similar to commit d6169b0206db ("net: Use ns_capable_noaudit() when
> > > determining net sysctl permissions")
> > > 
> > > Fixes: 7863dcc72d0f ("pid: allow pid_max to be set per pid namespace")
> > > CC: Christian Brauner <brauner@...nel.org>
> > > CC: linux-security-module@...r.kernel.org
> > > CC: selinux@...r.kernel.org
> > > Signed-off-by: Christian Göttsche <cgzones@...glemail.com>
> > > ---
> > >  kernel/pid.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Reviewed-by: Paul Moore <paul@...l-moore.com>
> 
> Thanks.
> 
> Acked-by: Serge Hallyn <serge@...lyn.com>
> 
> I'll queue this up in the capability tree, unless Christian wanted
> it in his.
> 
> -serge

I've included this in git://git.kernel.org/pub/scm/linux/kernel/git/sergeh/linux.git#caps-next

thanks,
-serge