linux-kernel - Re: [PATCH RFC 2/2] arm64: dts: qcom: qcs6490: Introduce Radxa Dragon Q6A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <156176d8-9b5c-49e4-9c17-c201255f50d4@kernel.org>
Date: Fri, 12 Sep 2025 10:15:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Xilin Wu <sophon@...xa.com>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Neil Armstrong <neil.armstrong@...aro.org>,
 Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>,
 Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>
Subject: Re: [PATCH RFC 2/2] arm64: dts: qcom: qcs6490: Introduce Radxa Dragon
 Q6A

On 12/09/2025 10:03, Xilin Wu wrote:
> Radxa Dragon Q6A is a single board computer, based on the Qualcomm
> QCS6490 platform.
> 
> This is currently posted as RFC. More details are in the cover letter.

Please drop this sentence. If this is applied, then commit would be just
misleading.

> 
> Signed-off-by: Xilin Wu <sophon@...xa.com>
> ---


...


> +&sound {
> +	compatible = "qcom,qcs6490-rb3gen2-sndcard";
> +	model = "QCS6490-Radxa-Dragon-Q6A";
> +
> +	audio-routing =
> +		"IN1_HPHL", "HPHL_OUT",
> +		"IN2_HPHR", "HPHR_OUT",
> +		"AMIC2", "MIC BIAS2",
> +		"TX SWR_ADC1", "ADC2_OUTPUT";
> +
> +	wcd-playback-dai-link {
> +		link-name = "WCD Playback";
> +
> +		cpu {
> +			sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>;
> +		};
> +
> +		codec {

If there is going to be new version, then codec before cpu (o < p, order
by name). But don't resend just for that.


> +			sound-dai = <&wcd938x 0>, <&swr0 0>, <&lpass_rx_macro 0>;
> +		};
> +

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


Best regards,
Krzysztof