linux-kernel - Re: [PATCH v2 2/2] ARM: rockchip: select ROCKCHIP_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUUQ_raSGTjLSU0QaBxy3CMMnJJTV9BKmWQLQ7U8VE3oA@mail.gmail.com>
Date: Fri, 12 Sep 2025 10:48:47 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Mikko Rapeli <mikko.rapeli@...aro.org>
Cc: linux-mmc@...r.kernel.org, ulf.hansson@...aro.org, 
	Heiko Stübner <heiko@...ech.de>, 
	linux-kernel@...r.kernel.org, adrian.hunter@...el.com, 
	victor.shih@...esyslogic.com.tw, ben.chuang@...esyslogic.com.tw, 
	geert+renesas@...der.be, angelogioacchino.delregno@...labora.com, 
	dlan@...too.org, arnd@...db.de, zhoubinbin@...ngson.cn
Subject: Re: [PATCH v2 2/2] ARM: rockchip: select ROCKCHIP_PM_DOMAINS

Hi Mikko,

On Fri, 12 Sept 2025 at 10:41, Mikko Rapeli <mikko.rapeli@...aro.org> wrote:
> According to Heiko Stuebner <heiko@...ech.de> all SoCs
> since 2012 have power domain support in HW and
> ROCKCHIP_PM_DOMAINS should always be enabled.
>
> Suggested-by: Heiko Stuebner <heiko@...ech.de>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@...aro.org>

Thanks for your patch!

> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -14,6 +14,7 @@ config ARCH_ROCKCHIP
>         select HAVE_ARM_TWD if SMP
>         select DW_APB_TIMER_OF
>         select REGULATOR if PM
> +       select ROCKCHIP_PM_DOMAINS

This requires "select PM". Oh, that is done below (out-of-context).
So the "if PM" above can be dropped.

>         select ROCKCHIP_TIMER
>         select ARM_GLOBAL_TIMER
>         select CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds