linux-kernel - Re: [PATCH v2 2/2] ARM: rockchip: select ROCKCHIP_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMP3Goa-IVjCmSHa@nuoska>
Date: Fri, 12 Sep 2025 13:34:02 +0300
From: Mikko Rapeli <mikko.rapeli@...aro.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: linux-mmc@...r.kernel.org, ulf.hansson@...aro.org,
	Heiko Stübner <heiko@...ech.de>,
	linux-kernel@...r.kernel.org, adrian.hunter@...el.com,
	victor.shih@...esyslogic.com.tw, ben.chuang@...esyslogic.com.tw,
	geert+renesas@...der.be, angelogioacchino.delregno@...labora.com,
	dlan@...too.org, arnd@...db.de, zhoubinbin@...ngson.cn
Subject: Re: [PATCH v2 2/2] ARM: rockchip: select ROCKCHIP_PM_DOMAINS

Hi,

On Fri, Sep 12, 2025 at 10:48:47AM +0200, Geert Uytterhoeven wrote:
> Hi Mikko,
> 
> On Fri, 12 Sept 2025 at 10:41, Mikko Rapeli <mikko.rapeli@...aro.org> wrote:
> > According to Heiko Stuebner <heiko@...ech.de> all SoCs
> > since 2012 have power domain support in HW and
> > ROCKCHIP_PM_DOMAINS should always be enabled.
> >
> > Suggested-by: Heiko Stuebner <heiko@...ech.de>
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@...aro.org>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm/mach-rockchip/Kconfig
> > +++ b/arch/arm/mach-rockchip/Kconfig
> > @@ -14,6 +14,7 @@ config ARCH_ROCKCHIP
> >         select HAVE_ARM_TWD if SMP
> >         select DW_APB_TIMER_OF
> >         select REGULATOR if PM
> > +       select ROCKCHIP_PM_DOMAINS
> 
> This requires "select PM". Oh, that is done below (out-of-context).
> So the "if PM" above can be dropped.

Yes, it's selected just after the context. I can drop it from
"select REGULATOR" in v3.

I was not sure if the PM dependency should be there or not
also when it's explicitly selected.

Cheers,

-Mikko