linux-kernel - Re: [PATCH v4 3/3] iio: pressure: bmp280: Use gpiod_set_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250913152351.4455efc2@jic23-huawei>
Date: Sat, 13 Sep 2025 15:23:51 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Salah Triki <salah.triki@...il.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, dlechner@...libre.com, nuno.sa@...log.com,
 andy@...nel.org, Markus.Elfring@....de
Subject: Re: [PATCH v4 3/3] iio: pressure: bmp280: Use
 gpiod_set_value_cansleep()

On Wed, 20 Aug 2025 17:51:22 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Mon, Aug 18, 2025 at 10:27:32AM +0100, Salah Triki wrote:
> > Switch to `gpiod_set_value_cansleep()`, which is safe to use in
> > sleepable contexts like the driver probe function.  
> 
> The commit message is unclear on why? aspect. You need to elaborate that some
> GPIO chips may be located behind slow (and hence sleepable) busses, such as
> I²C).
> 
> Code wise I agree with the change.
> With amended commit message
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 

I added a brief not on slow buses and applied.

Thanks,

Jonathan