linux-kernel - Re: [PATCH 11/11] arm64: dts: qcom: sdm845-lg-common: Sort and cleanup nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <31e7e9c3-c8e9-4b93-86a1-7c65818bac86@kernel.org>
Date: Sun, 14 Sep 2025 12:24:23 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Paul Sajna <sajattack@...tmarketos.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, David Heidelberg <david@...t.cz>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Amir Dahan <system64fumo@...tonmail.com>,
 Christopher Brown <crispybrown@...il.com>
Subject: Re: [PATCH 11/11] arm64: dts: qcom: sdm845-lg-common: Sort and
 cleanup nodes

On 14/09/2025 01:56, Paul Sajna wrote:
> Fix style issues and sort alphabetically

What style issues? Why are you re-sorting this? Answer to these in the
commit msg.


> 
> Signed-off-by: Paul Sajna <sajattack@...tmarketos.org>




> -&uart6 {
> -	pinctrl-0 = <&qup_uart6_4pin>;
> -
> -	status = "okay";
> +&usb_1_hsphy {
> +	vdd-supply = <&vdda_usb1_ss_core>;
> +	vdda-pll-supply = <&vdda_qusb_hs0_1p8>;
> +	vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>;
>  
> -	bluetooth {
> -		compatible = "qcom,wcn3990-bt";
> +	qcom,imp-res-offset-value = <8>;
> +	qcom,hstx-trim-value = <QUSB2_V2_HSTX_TRIM_21_6_MA>;
> +	qcom,preemphasis-level = <QUSB2_V2_PREEMPHASIS_5_PERCENT>;
> +	qcom,preemphasis-width = <QUSB2_V2_PREEMPHASIS_WIDTH_HALF_BIT>;
>  
> -		vddio-supply = <&vreg_s4a_1p8>;
> -		vddxo-supply = <&vreg_l7a_1p8>;
> -		vddrf-supply = <&vreg_l17a_1p3>;
> -		vddch0-supply = <&vreg_l25a_3p3>;
> -		max-speed = <3200000>;

You just added all these on other patch, no? Don't add code which is
knowingly incorrect or have to be immediately adjusted. Probably you
organized the patchset wrong and any sorting should be done earlier,
assuming that we want this sorting in the first place?


Best regards,
Krzysztof