linux-kernel - Re: [PATCH 01/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <djduil6xb65qxmjp5qrxliskjii2nbijnd4w4rwsz4d7nmpo4f@crut3ib4hu6y>
Date: Mon, 15 Sep 2025 03:19:47 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Paul Sajna <sajattack@...tmarketos.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, David Heidelberg <david@...t.cz>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Amir Dahan <system64fumo@...tonmail.com>,
        Christopher Brown <crispybrown@...il.com>
Subject: Re: [PATCH 01/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and
 Bluetooth

On Sat, Sep 13, 2025 at 04:56:34PM -0700, Paul Sajna wrote:
> uart9 is debug serial on USB SBU1/2
> uart6 is bluetooth
> 
> Signed-off-by: Paul Sajna <sajattack@...tmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 47 ++++++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 10 ++++++
>  2 files changed, 57 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 99dafc6716e76e25aad0755e6004dc952779689f..1acc418b943443f3ba4f8a8a1cfe2c575da11876 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -31,6 +31,8 @@ chosen {
>  		#address-cells = <2>;
>  		#size-cells = <2>;
>  		ranges;
> +
> +		stdout-path = "serial0:115200n8";
>  	};
>  
>  	reserved-memory {
> @@ -159,6 +161,11 @@ vreg_s4a_1p8: pm8998-smps4-regulator {
>  
>  		vin-supply = <&vph_pwr>;
>  	};
> +
> +	aliases {

Please keep the file sorted. 'aliases' < 'chosen', etc.

> +		serial0 = &uart9;
> +		serial1 = &uart6;
> +	};
>  };
>  
>  &adsp_pas {
> @@ -595,3 +602,43 @@ vol_up_pin_a: vol-up-active-state {
>  		qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
>  	};
>  };
> +
> +&qupv3_id_0 {
> +	status = "okay";
> +};
> +
> +&qupv3_id_1 {
> +	status = "okay";
> +};
> +
> +&qup_uart9_rx {
> +	drive-strength = <2>;
> +	bias-pull-up;
> +};
> +
> +&qup_uart9_tx {
> +	drive-strength = <2>;
> +	bias-disable;
> +};
> +
> +&uart6 {
> +	pinctrl-0 = <&qup_uart6_4pin>;
> +
> +	status = "okay";
> +
> +	bluetooth {
> +		compatible = "qcom,wcn3990-bt";
> +
> +		vddio-supply = <&vreg_s4a_1p8>;
> +		vddxo-supply = <&vreg_l7a_1p8>;
> +		vddrf-supply = <&vreg_l17a_1p3>;
> +		vddch0-supply = <&vreg_l25a_3p3>;
> +		max-speed = <3200000>;
> +	};
> +};
> +
> +&uart9 {
> +	label = "LS-UART1";
> +
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index a12723310c8b630a4961de671ea8b60f1f8b512b..49225e4fa80e5f45a36964d5d733dc238e4413f8 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -66,3 +66,13 @@ thinq_key_default: thinq-key-default-state {
>  		bias-pull-up;
>  	};
>  };
> +
> +&uart6 {
> +	bluetooth {
> +		/*
> +		 * This path is relative to the qca/
> +		 * subdir under lib/firmware.

Why do you need a special NV file? Please include BT information into
the commit message. Also, if qca_read_fw_board_id() returns a sensible
information on this board, it would be better to fix btqca driver to
apply board ID on WCN399x boards too.

> +		 */
> +		firmware-name = "judyln/crnv21.bin";
> +	};
> +};
> 
> -- 
> 2.51.0
> 

-- 
With best wishes
Dmitry