linux-kernel - Re: [PATCH v2 1/4] dt-bindings: clock: mediatek: Add MT8189 clock definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82391eba-263d-42d8-9335-6b4bab6a3412@kernel.org>
Date: Sun, 14 Sep 2025 14:03:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "irving.ch.lin" <irving-ch.lin@...iatek.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Ulf Hansson <ulf.hansson@...aro.org>,
 Richard Cochran <richardcochran@...il.com>
Cc: Qiqi Wang <qiqi.wang@...iatek.com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 linux-pm@...r.kernel.org, netdev@...r.kernel.org,
 Project_Global_Chrome_Upstream_Group@...iatek.com, sirius.wang@...iatek.com,
 vince-wl.liu@...iatek.com, jh.hsu@...iatek.com
Subject: Re: [PATCH v2 1/4] dt-bindings: clock: mediatek: Add MT8189 clock
 definitions

On 12/09/2025 14:04, irving.ch.lin wrote:
> From: Irving-ch Lin <irving-ch.lin@...iatek.com>
> 
> Add device tree bindings for the clock of MediaTek MT8189 SoC.
> These definitions will be used to describe the clock topology in
> device tree sources.

Drop last sentence, completely redundant. It cannot be anything else...

> 
> Signed-off-by: Irving-ch Lin <irving-ch.lin@...iatek.com>
> ---

That's a v2, so where is any changelog? Nothing here nor in cover
letter. No changes, so you did not fix any of the bugs you had last time?

Why aren't you using b4 to submit patches which would handle this? If
you prefer to use older method, then fine but do it right.


>  .../bindings/clock/mediatek,mt8189-clock.yaml |  89 +++
>  .../clock/mediatek,mt8189-sys-clock.yaml      |  58 ++
>  .../dt-bindings/clock/mediatek,mt8189-clk.h   | 580 ++++++++++++++++++
>  3 files changed, 727 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8189-clock.yaml
>  create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8189-sys-clock.yaml
>  create mode 100644 include/dt-bindings/clock/mediatek,mt8189-clk.h
> 
Best regards,
Krzysztof