linux-kernel - Re: [PATCH v2 1/6] dt-bindings: rtc: Add ST m41t93

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250915141951.GA3239298@bhairav-test.ee.iitb.ac.in>
Date: Mon, 15 Sep 2025 19:49:51 +0530
From: Akhilesh Patil <akhilesh@...iitb.ac.in>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: alexandre.belloni@...tlin.com, krzk+dt@...nel.org, robh@...nel.org,
	conor+dt@...nel.org, skhan@...uxfoundation.org,
	linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, akhileshpatilvnit@...il.com
Subject: Re: [PATCH v2 1/6] dt-bindings: rtc: Add ST m41t93

On Thu, Sep 11, 2025 at 09:43:09AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Sep 10, 2025 at 07:22:33PM +0530, Akhilesh Patil wrote:
> > Document DT bindings for m41t93 rtc which supports time, date,
> > alarm, watchdog, square wave clock output provider, user sram
> > and 8 bit timer.
> > 
> > Signed-off-by: Akhilesh Patil <akhilesh@...iitb.ac.in>
> > ---
> >  .../devicetree/bindings/rtc/st,m41t93.yaml    | 50 +++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/st,m41t93.yaml b/Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> > new file mode 100644
> > index 000000000000..bd593669cfa2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/st,m41t93.yaml
> > @@ -0,0 +1,50 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/st,m41t93.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ST M41T93 RTC and compatible
> > +
> > +maintainers:
> > +  - linux-rtc@...r.kernel.org
> 
> Not much improved. This should be a person responsible/caring about this
> hardware support in the kernel. Why would we want to take the binding if
> no one cares about it?

Okay. As per get_maintainer.pl, linux driver corresponding to this binding does not have a dedicated
maintainer, hence it shows rtc subsystem maintainer (Alexandre Belloni).
Looking forward for your suggestion here.
What do you suggest to keep maintainer as Rob Herring or/and me ? as I see in
such cases Rob is the maintainer.

> 
> > +
> > +description: |
> 
> Do not need '|' unless you need to preserve formatting.

Sure. I will remove this. Thanks for pointing it out.

> 
> > +  ST M41T93 is spi based Real Time Clock (RTC) with time, date,
> > +  alarm, watchdog, square wave clock output, 8 bit timer and
> > +  7 bytes of user SRAM.
> 
> Best regards,
> Krzysztof

Regards,
Akhilesh