linux-kernel - Re: [PATCH v18 00/33] x86,fs/resctrl: Support AMD Assignable Bandwidth Monitoring Counters (ABMC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b56757b8-3055-455d-b31b-28094dd46231@intel.com>
Date: Mon, 15 Sep 2025 14:07:26 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Borislav Petkov <bp@...en8.de>, Babu Moger <babu.moger@....com>
CC: <corbet@....net>, <tony.luck@...el.com>, <Dave.Martin@....com>,
	<james.morse@....com>, <tglx@...utronix.de>, <mingo@...hat.com>,
	<dave.hansen@...ux.intel.com>, <x86@...nel.org>, <hpa@...or.com>,
	<kas@...nel.org>, <rick.p.edgecombe@...el.com>, <akpm@...ux-foundation.org>,
	<paulmck@...nel.org>, <frederic@...nel.org>, <pmladek@...e.com>,
	<rostedt@...dmis.org>, <kees@...nel.org>, <arnd@...db.de>, <fvdl@...gle.com>,
	<seanjc@...gle.com>, <thomas.lendacky@....com>,
	<pawan.kumar.gupta@...ux.intel.com>, <perry.yuan@....com>,
	<manali.shukla@....com>, <sohil.mehta@...el.com>, <xin@...or.com>,
	<Neeraj.Upadhyay@....com>, <peterz@...radead.org>, <tiala@...rosoft.com>,
	<mario.limonciello@....com>, <dapeng1.mi@...ux.intel.com>,
	<michael.roth@....com>, <chang.seok.bae@...el.com>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-coco@...ts.linux.dev>, <kvm@...r.kernel.org>,
	<peternewman@...gle.com>, <eranian@...gle.com>, <gautham.shenoy@....com>
Subject: Re: [PATCH v18 00/33] x86,fs/resctrl: Support AMD Assignable
 Bandwidth Monitoring Counters (ABMC)

Hi Boris,

On 9/15/25 4:25 AM, Borislav Petkov wrote:
> On Fri, Sep 05, 2025 at 04:33:59PM -0500, Babu Moger wrote:
>>  .../admin-guide/kernel-parameters.txt         |    2 +-
>>  Documentation/filesystems/resctrl.rst         |  325 ++++++
>>  MAINTAINERS                                   |    1 +
>>  arch/x86/include/asm/cpufeatures.h            |    1 +
>>  arch/x86/include/asm/msr-index.h              |    2 +
>>  arch/x86/include/asm/resctrl.h                |   16 -
>>  arch/x86/kernel/cpu/resctrl/core.c            |   81 +-
>>  arch/x86/kernel/cpu/resctrl/internal.h        |   56 +-
>>  arch/x86/kernel/cpu/resctrl/monitor.c         |  248 +++-
>>  arch/x86/kernel/cpu/scattered.c               |    1 +
>>  fs/resctrl/ctrlmondata.c                      |   26 +-
>>  fs/resctrl/internal.h                         |   58 +-
>>  fs/resctrl/monitor.c                          | 1008 ++++++++++++++++-
>>  fs/resctrl/rdtgroup.c                         |  252 ++++-
>>  include/linux/resctrl.h                       |  148 ++-
>>  include/linux/resctrl_types.h                 |   18 +-
>>  16 files changed, 2019 insertions(+), 224 deletions(-)
> 
> Ok, I've rebased and pushed out the pile into tip:x86/cache.
> 
> Please run it one more time to make sure all is good.

Thank you very much.

I successfully completed as much testing as I can do without the hardware that has
the feature. Will leave the actual feature sanity check to Babu.

As far as the patches goes ...

I noticed that you modified most changelogs to use closer to 80 characters per line,
max of 81 characters. Considering this I plan to ignore the checkpatch.pl "Prefer a maximum
75 chars per line ..." warning from now on when it comes to changelogs and replace it with
a check for 80 characters with same guidance to resctrl contributors.

Thank you very much for catching and fixing the non-ASCII characters in patch #29. I 
added a new patch check step that checks for non-ASCII characters.

Reinette