linux-kernel - Re: [PATCH v2 3/4] clk: mediatek: Add clock drivers for MT8189 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250915075425.GE8224@nxa18884-linux.ap.freescale.net>
Date: Mon, 15 Sep 2025 15:54:25 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: "irving.ch.lin" <irving-ch.lin@...iatek.com>
Cc: Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Richard Cochran <richardcochran@...il.com>,
	Qiqi Wang <qiqi.wang@...iatek.com>, linux-clk@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, linux-pm@...r.kernel.org,
	netdev@...r.kernel.org,
	Project_Global_Chrome_Upstream_Group@...iatek.com,
	sirius.wang@...iatek.com, vince-wl.liu@...iatek.com,
	jh.hsu@...iatek.com
Subject: Re: [PATCH v2 3/4] clk: mediatek: Add clock drivers for MT8189 SoC

Hi Irving-ch,

On Fri, Sep 12, 2025 at 08:04:52PM +0800, irving.ch.lin wrote:
>From: Irving-ch Lin <irving-ch.lin@...iatek.com>
>
>Introduce a new clock (clk) driver port for the MediaTek
>MT8189 SoC. The driver is newly implemented based on the hardware
>layout and register settings of the MT8189 chip, enabling correct clk
>management and operation for various modules.
>
>With clock topology, we need to register clock sequence below:
>apmixedsys(pll) -> topckgen(div/mux) -> others(cgs)
>
>Signed-off-by: Irving-ch Lin <irving-ch.lin@...iatek.com>
>---
> drivers/clk/mediatek/Kconfig                 |  146 +++
> drivers/clk/mediatek/Makefile                |   14 +
> drivers/clk/mediatek/clk-mt8189-apmixedsys.c |  135 +++
> drivers/clk/mediatek/clk-mt8189-bus.c        |  289 +++++
> drivers/clk/mediatek/clk-mt8189-cam.c        |  131 +++
> drivers/clk/mediatek/clk-mt8189-dbgao.c      |  115 ++
> drivers/clk/mediatek/clk-mt8189-dvfsrc.c     |   61 +
> drivers/clk/mediatek/clk-mt8189-iic.c        |  149 +++
> drivers/clk/mediatek/clk-mt8189-img.c        |  122 ++
> drivers/clk/mediatek/clk-mt8189-mdpsys.c     |  100 ++
> drivers/clk/mediatek/clk-mt8189-mfg.c        |   56 +
> drivers/clk/mediatek/clk-mt8189-mmsys.c      |  233 ++++
> drivers/clk/mediatek/clk-mt8189-scp.c        |   92 ++
> drivers/clk/mediatek/clk-mt8189-topckgen.c   | 1057 ++++++++++++++++++
> drivers/clk/mediatek/clk-mt8189-ufs.c        |  106 ++
> drivers/clk/mediatek/clk-mt8189-vcodec.c     |  119 ++
> drivers/clk/mediatek/clk-mt8189-vlpcfg.c     |  145 +++
> drivers/clk/mediatek/clk-mt8189-vlpckgen.c   |  280 +++++
> drivers/clk/mediatek/clk-mux.c               |    4 +
> 19 files changed, 3354 insertions(+)

This is too much changes in a single patch. Prefer to separate
into small patches in next version, otherwise it is hard to review.

Regards
Peng