linux-kernel - Re: [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMe52k8wtQBU-eyN@nuoska>
Date: Mon, 15 Sep 2025 10:01:46 +0300
From: Mikko Rapeli <mikko.rapeli@...aro.org>
To: Arnd Bergmann <arnd@...db.de>, Binbin Zhou <zhoubinbin@...ngson.cn>
Cc: "linux-mmc @ vger . kernel . org" <linux-mmc@...r.kernel.org>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Heiko Stübner <heiko@...ech.de>,
	linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	Victor Shih <victor.shih@...esyslogic.com.tw>,
	Ben Chuang <ben.chuang@...esyslogic.com.tw>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Yixun Lan <dlan@...too.org>, zhoubb.aaron@...il.com
Subject: Re: [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2

Hi,

On Fri, Sep 12, 2025 at 04:50:38PM +0200, Arnd Bergmann wrote:
> On Fri, Sep 12, 2025, at 16:22, Mikko Rapeli wrote:
> > It fails to link due to undeclared dependency
> > to regmap which is not enabled for COMPILE_TEST:
> >
> > ERROR: modpost: "__devm_regmap_init_mmio_clk"
> > [drivers/mmc/host/loongson2-mmc.ko] undefined!
> 
> Nice catch! I assume my normal randconfig builds never
> run into this because there is always something selecting
> REGMAP_MMIO.
> 
> >  config MMC_LOONGSON2
> >  	tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> > -	depends on LOONGARCH || COMPILE_TEST
> > +	depends on LOONGARCH
> >  	depends on HAS_DMA
> 
> I would instead add 'select REGMAP_MMIO' here, which is what
> we do for other drivers using this.

On Sat, Sep 13, 2025 at 12:58:00PM +0800, Binbin Zhou wrote:
<snip>
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -1113,7 +1113,7 @@ config MMC_OWL
> >   config MMC_LOONGSON2
> >   	tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> > -	depends on LOONGARCH || COMPILE_TEST
> > +	depends on LOONGARCH
> 
> How about add `select REGMAP_MMIO` instead.

Sorry, my bad. I just checked drivers/base/regmap/Kconfig for COMPILE_TEST
and since it was not found thought that it's not supported with
COMPILE_TEST.

I will add the REGMAP_MMIO dependency instead in v4.

Cheers,

-Mikko