linux-kernel - Re: [PATCH 07/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yneazsozjexv4b7gvzcdecv3zdzzbbscqg2vil3czdeqtdrdbf@l73eggl6y6uc>
Date: Mon, 15 Sep 2025 03:33:49 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Paul Sajna <sajattack@...tmarketos.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, David Heidelberg <david@...t.cz>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Amir Dahan <system64fumo@...tonmail.com>,
        Christopher Brown <crispybrown@...il.com>
Subject: Re: [PATCH 07/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware
 nodes

On Sat, Sep 13, 2025 at 04:56:40PM -0700, Paul Sajna wrote:
> Firmware nodes added for ipa, modem, bluetooth, venus
> 
> adsp and cdsp enabled

I'm not sure what is written here. Please describe the change according
to Documentation/process/submitting-patches.rst

> 
> Signed-off-by: Paul Sajna <sajattack@...tmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
>  arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  |  8 ++++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 585582ff4e0bbe8c994328278d5e5dd3a280ddb6..cc1c78162eedd50d30a70810ac3790efe6c0492f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -173,6 +173,10 @@ &adsp_pas {
>  	status = "okay";
>  };
>  
> +&cdsp_pas {
> +	status = "okay";
> +};
> +
>  &apps_rsc {
>  	regulators-0 {
>  		compatible = "qcom,pm8998-rpmh-regulators";
> @@ -483,6 +487,8 @@ zap-shader {
>  
>  &ipa {
>  	qcom,gsi-loader = "modem";
> +	memory-region = <&ipa_fw_mem>;
> +
>  	status = "okay";
>  };
>  
> @@ -683,6 +689,10 @@ &uart9 {
>  	status = "okay";
>  };
>  
> +&venus {
> +	status = "okay";
> +};
> +
>  &wifi {
>  	vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
>  	vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index fae85d4c1520e044d8166bb22a8f5762fda250b2..1596a3408659323d60f1b7c395098ed628782dfa 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -70,6 +70,10 @@ zap-shader {
>  	};
>  };
>  
> +&ipa {
> +	firmware-name = "qcom/sdm845/judyln/ipa_fws.mbn";

Note: it should be qcom/sdm845/lg/judyln/.... (or qcom/sdm845/LG/judyln)
Would you mind fixing it to follow the convention?

> +};
> +
>  &mss_pil {
>  	firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
>  };
> @@ -190,3 +194,7 @@ bluetooth {
>  		firmware-name = "judyln/crnv21.bin";
>  	};
>  };
> +
> +&venus {
> +	firmware-name = "qcom/sdm845/judyln/venus.mbn";
> +};
> 
> -- 
> 2.51.0
> 

-- 
With best wishes
Dmitry