linux-kernel - Re: [PATCH 04/11] arm64: dts: qcom: sdm845-lg-common: Add camera flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ja4oeddeirvmtqx7lmxxjwp476hskstxmvb7iaajy47zil7bqa@oubzrtrdrvw2>
Date: Mon, 15 Sep 2025 03:34:24 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Paul Sajna <sajattack@...tmarketos.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, David Heidelberg <david@...t.cz>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Amir Dahan <system64fumo@...tonmail.com>,
        Christopher Brown <crispybrown@...il.com>
Subject: Re: [PATCH 04/11] arm64: dts: qcom: sdm845-lg-common: Add camera
 flash

On Mon, Sep 15, 2025 at 03:25:45AM +0300, Dmitry Baryshkov wrote:
> On Sat, Sep 13, 2025 at 04:56:37PM -0700, Paul Sajna wrote:
> > Add the camera flash so it can be used as a flashlight
> > 
> > Co-authored-by: Amir Dahan <system64fumo@...tonmail.com>
> > Signed-off-by: Amir Dahan <system64fumo@...tonmail.com>
> > Signed-off-by: Paul Sajna <sajattack@...tmarketos.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> > index d6129ce03f537f0c8c78c2ae5f39be6146cab7dc..df826bca2bef5e3f85cf49708020a47b8d6bd8bb 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> > @@ -604,6 +604,20 @@ vol_up_pin_a: vol-up-active-state {
> >  	};
> >  };
> >  
> > +&pmi8998_flash {
> > +	status = "okay";
> > +
> > +	led-0 {
> > +		label = "flash";
> 
> Not allowed, please drop.

Okay, allowed, but still please drop. See how it's handled for other
boards.

> 
> > +		function = LED_FUNCTION_FLASH;
> > +		color = <LED_COLOR_ID_WHITE>;
> > +		led-sources = <1>;
> > +		led-max-microamp = <850000>;
> > +		flash-max-microamp = <850000>;
> > +		flash-max-timeout-us = <500000>;
> > +	};
> > +};
> > +
> >  &pmi8998_lpg {
> >  	status = "okay";
> >  
> > 
> > -- 
> > 2.51.0
> > 
> 
> -- 
> With best wishes
> Dmitry

-- 
With best wishes
Dmitry