linux-kernel - Re: [PATCH v2 2/5] arm64: dts: qcom: qcs6490: Introduce Radxa Dragon Q6A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7B118B34491945E2+c5440518-0874-405a-841c-7d9e43b51d1d@radxa.com>
Date: Mon, 15 Sep 2025 09:20:11 +0800
From: Xilin Wu <sophon@...xa.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Neil Armstrong <neil.armstrong@...aro.org>,
 Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>,
 Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2 2/5] arm64: dts: qcom: qcs6490: Introduce Radxa Dragon
 Q6A

On 9/15/2025 1:39 AM, Krzysztof Kozlowski wrote:
> On 14/09/2025 17:57, Xilin Wu wrote:
>> Radxa Dragon Q6A is a single board computer, based on the Qualcomm
>> QCS6490 platform.
>>
>> Features enabled and working:
>>
>> - Three USB-A 2.0 ports
>> - RTL8111K Ethernet connected to PCIe0
>> - eMMC module
>> - SD card
>> - M.2 M-Key 2230 PCIe 3.0 x2
>> - Headphone jack
>> - Onboard thermal sensors
>> - QSPI controller for updating boot firmware
>> - ADSP remoteproc (Type-C and charging features disabled in firmware)
>> - CDSP remoteproc (for AI applications using QNN)
>> - Venus video encode and decode accelerator
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> I see huge diff, like 200-300 lines being changed against v1 and you
> claim that I reviewed this one?
> 
> No, that's not true. Please read submitting patches - if you change
> significantly the patch, you must drop the tag and explain the reason.
> 
> NAK, unreviewed.
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof,

Thanks for your detailed review and clear feedback. My apologies for 
misusing the Reviewed-by tag on a modified patch and for incorrectly 
declaring dependencies in the DTS patches. I will address the issues in 
the next series.

Thanks again for your guidance.

-- 
Best regards,
Xilin Wu <sophon@...xa.com>