linux-kernel - RE: [PATCH v2 3/7] can: rcar_canfd: Move enabling of RAM clk from probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB11332E5715ED698954A87CABD8615A@TYCPR01MB11332.jpnprd01.prod.outlook.com>
Date: Mon, 15 Sep 2025 11:36:45 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: geert <geert@...ux-m68k.org>, biju.das.au <biju.das.au@...il.com>
CC: Marc Kleine-Budde <mkl@...gutronix.de>, Vincent Mailhol
	<mailhol.vincent@...adoo.fr>, magnus.damm <magnus.damm@...il.com>,
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Prabhakar
 Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: RE: [PATCH v2 3/7] can: rcar_canfd: Move enabling of RAM clk from
 probe()

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: 15 September 2025 12:31
> Subject: Re: [PATCH v2 3/7] can: rcar_canfd: Move enabling of RAM clk from probe()
> 
> Hi Biju,
> 
> Thanks for your patch!
> 
> On Fri, 12 Sept 2025 at 12:47, Biju <biju.das.au@...il.com> wrote:
> > From: Biju Das <biju.das.jz@...renesas.com>
> >
> > The RAM clk needs to be enabled in resume for proper operation in STR
> > mode for RZ/G3E SoC. This change also result in less power consumption.
> 
> results
> 
> Note that after this patch, the amount of power consumption is unchanged,  as the RAM clock is still
> enabled during probe, and disabled during remove.

Oops, yes you are correct.

> 
> I suspect that on RZ/G3E the RAM clock was disabled after resume?

CANFD won't work if this clock is disabled during resume().

OK, I will update the commit message removing the wrong wording.

Cheers,
Biju