linux-kernel - Re: [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca511d42-0381-41d1-bea0-0d766e04f9f4@linaro.org>
Date: Tue, 16 Sep 2025 15:12:16 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Anup Kulkarni <anup.kulkarni@....qualcomm.com>,
 gregkh@...uxfoundation.org, jirislaby@...nel.org, johan+linaro@...nel.org,
 dianders@...omium.org, quic_ptalari@...cinc.com, quic_zongjian@...cinc.com,
 quic_jseerapu@...cinc.com, quic_vdadhani@...cinc.com,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org
Cc: mukesh.savaliya@....qualcomm.com, viken.dadhaniya@....qualcomm.com,
 stable@...r.kernel.org
Subject: Re: [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for
 RS485 mode

On 16/09/2025 10:39, Anup Kulkarni wrote:
> If uart_get_rs485() fails, the driver returns without detaching
> the PM domain list.
> 
> Fix the error handling path in uart_get_rs485_mode() to ensure the
> PM domain list is detached before exiting.
> 
> Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms")
> Cc: stable@...r.kernel.org
> Signed-off-by: Anup Kulkarni <anup.kulkarni@....qualcomm.com>
> ---
>   drivers/tty/serial/qcom_geni_serial.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 9c7b1cea7cfe..0fc0f215b85c 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -1928,7 +1928,7 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
>   
>   	ret = uart_get_rs485_mode(uport);
>   	if (ret)
> -		return ret;
> +		goto error;
>   
>   	devm_pm_runtime_enable(port->se.dev);
>   
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>