linux-kernel - [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250916093957.4058328-1-anup.kulkarni@oss.qualcomm.com>
Date: Tue, 16 Sep 2025 15:09:57 +0530
From: Anup Kulkarni <anup.kulkarni@....qualcomm.com>
To: gregkh@...uxfoundation.org, jirislaby@...nel.org, johan+linaro@...nel.org,
        dianders@...omium.org, quic_ptalari@...cinc.com,
        bryan.odonoghue@...aro.org, quic_zongjian@...cinc.com,
        anup.kulkarni@....qualcomm.com, quic_jseerapu@...cinc.com,
        quic_vdadhani@...cinc.com, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Cc: mukesh.savaliya@....qualcomm.com, viken.dadhaniya@....qualcomm.com,
        stable@...r.kernel.org
Subject: [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode

If uart_get_rs485() fails, the driver returns without detaching
the PM domain list.

Fix the error handling path in uart_get_rs485_mode() to ensure the
PM domain list is detached before exiting.

Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms")
Cc: stable@...r.kernel.org
Signed-off-by: Anup Kulkarni <anup.kulkarni@....qualcomm.com>
---
 drivers/tty/serial/qcom_geni_serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 9c7b1cea7cfe..0fc0f215b85c 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -1928,7 +1928,7 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
 
 	ret = uart_get_rs485_mode(uport);
 	if (ret)
-		return ret;
+		goto error;
 
 	devm_pm_runtime_enable(port->se.dev);
 
-- 
2.34.1