linux-kernel - Re: [PATCH v1] smp: Fix up and expand the smp_call_function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gEh-xoKdgAgUvnGzPV6AO51=ZagHXNCrC4BfRZk6Oydw@mail.gmail.com>
Date: Tue, 16 Sep 2025 16:13:24 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: LKML <linux-kernel@...r.kernel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Randy Dunlap <rdunlap@...radead.org>, 
	Linux PM <linux-pm@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v1] smp: Fix up and expand the smp_call_function_many() kerneldoc

On Tue, Sep 9, 2025 at 1:44 PM Rafael J. Wysocki <rafael@...nel.org> wrote:
>
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> The smp_call_function_many() kerneldoc comment got out of sync with the
> function definition (bool parameter "wait" is incorrectly described as a
> bitmask in it), so fix it up by copying the "wait" description from the
> smp_call_function() kerneldoc and add information regarding the handling
> of the local CPU to it.
>
> Fixes: 49b3bd213a9f ("smp: Fix all kernel-doc warnings")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

It's been a week and no feedback.

Well, in the further absence of any, I'll assume no concerns and just
queue this up.

> ---
>  kernel/smp.c |   11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -884,16 +884,15 @@ static void smp_call_function_many_cond(
>   * @mask: The set of cpus to run on (only runs on online subset).
>   * @func: The function to run. This must be fast and non-blocking.
>   * @info: An arbitrary pointer to pass to the function.
> - * @wait: Bitmask that controls the operation. If %SCF_WAIT is set, wait
> - *        (atomically) until function has completed on other CPUs. If
> - *        %SCF_RUN_LOCAL is set, the function will also be run locally
> - *        if the local CPU is set in the @cpumask.
> - *
> - * If @wait is true, then returns once @func has returned.
> + * @wait: If true, wait (atomically) until function has completed
> + *        on other CPUs.
>   *
>   * You must not call this function with disabled interrupts or from a
>   * hardware interrupt handler or from a bottom half handler. Preemption
>   * must be disabled when calling this function.
> + *
> + * @func is not called on the local CPU even if @mask contains it.  Consider
> + * using on_each_cpu_cond_mask() instead if this is not desirable.
>   */
>  void smp_call_function_many(const struct cpumask *mask,
>                             smp_call_func_t func, void *info, bool wait)
>
>
>
>