linux-kernel - Re: [PATCH RFC 05/13] dmaengine: sdxi: Add software data structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63a87cb6-5859-49a8-9f3c-151a962085c2@web.de>
Date: Tue, 16 Sep 2025 11:38:11 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Nathan Lynch <nathan.lynch@....com>, Wei Huang <wei.huang2@....com>,
 dmaengine@...r.kernel.org, linux-pci@...r.kernel.org,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Mario Limonciello <mario.limonciello@....com>, Vinod Koul <vkoul@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC 05/13] dmaengine: sdxi: Add software data structures

…
> +++ b/drivers/dma/sdxi/sdxi.h
> @@ -0,0 +1,206 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * SDXI device driver header
> + *
> + * Copyright (C) 2025 Advanced Micro Devices, Inc.
> + */
> +
> +#ifndef __SDXI_H
> +#define __SDXI_H
…

Do you find the usage of leading underscores still appropriate for such an identifier?
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
https://en.wikipedia.org/wiki/Include_guard#Difficulties

Regards,
Markus